Review main Merged

5745[TASK] Add CSS Class to special input types in FORM

Ingo Pfennigstorf CR +2 V +2 Easy +5 −2 updated 06/03/13, 20:49

Commit message

All input elements are wrapped by a list element that only has one
css class containing the element id of the field. To avoid unneccesary
barriers to ie. hide inputs field of the type "hidden" an extra class
is added to the list element to determine the field type of the
wrapped element, ie. hidden, text, ... .

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Steffen Ritter +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 13

  1. Steffen Ritter merged patch set 1 11/29/11, 15:28

  2. Georg Ringer commented on patch set 1 11/29/11, 15:28

    Do not submit

    Abstract.php:397

    whitespaces

    Abstract.php:399

    i really would like to see a htmlspecialchars there!
  3. Ingo Pfennigstorf uploaded patch set 2 11/29/11, 15:28

  4. Stefan Neufeind commented on patch set 3 11/29/11, 15:28

    Looks good to me, but someone else must approve
  5. Stefan Neufeind commented on patch set 3 11/29/11, 15:28

    oh, please note it's not 4.6 as commit-message says. We might want to look if we want this behaviour in previous releases as well, since it won't brake but maybe help some things. But you might also argue it a new "feature" :-)
  6. Georg Ringer commented on patch set 3 11/29/11, 15:28

    Verified; Looks good to me, but someone else must approve
  7. Steffen Ritter commented on patch set 3 V 0 11/29/11, 15:28

    by team member; Looks good to me, approved
  8. Ingo Pfennigstorf uploaded patch set 3 11/29/11, 15:28

  9. Mr. Jenkins commented on patch set 1 11/29/11, 15:28

  10. Mr. Jenkins commented on patch set 1 11/29/11, 15:28

  11. Mr. Jenkins commented on patch set 2 11/29/11, 15:28

  12. Mr. Jenkins commented on patch set 3 11/29/11, 15:28

  13. Oliver Hader commented on patch set 3 11/29/11, 15:28