57453[TASK] Improve custom CE explanation in FSC
Commit message
Review
-
Code review CR +2
- Mathias Brodala +2
- Björn Jacob +1
- Sybille Peters +1
- Karavas Aristeidis +1
-
Verified V +2
- Mathias Brodala +2
- Björn Jacob +1
- Sybille Peters +1
- Karavas Aristeidis +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
Mathias Brodala uploaded patch set 1 07/03/18, 07:27
-
TYPO3com voted on patch set 1 V +1 07/03/18, 07:35 Completed build in 07m 55s on Tue, 3 Jul, 09:35 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25057
-
Björn Jacob commented on patch set 1 V -1 07/03/18, 07:51
Index.rst:173Superflous. -
Mathias Brodala commented on patch set 2 07/03/18, 07:55
Published edit on patch set 1. -
Mathias Brodala commented on patch set 1 07/03/18, 07:55
Index.rst:169ReplyThat's what I tried to make clear with the "within lib.contentElement") since the whole construct is easier to understand once you know that "yourextensionkey_newcontentelement" is a FLUIDTEMPLATE content object. -
Björn Jacob commented on patch set 2 07/03/18, 07:59
Okay, thx Mathias. I see. Your explanation is better now. I am wondering if you should add that "lib.contentElement" is a FLUIDTEMPLATE object and can be found here: EXT:fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript? With this addition it is absolutely fault-proof. -
TYPO3com voted on patch set 2 V +1 07/03/18, 08:03 Completed build in 07m 51s on Tue, 3 Jul, 10:03 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25060
-
Mathias Brodala commented on patch set 3 07/03/18, 08:08
Published edit on patch set 2. -
Björn Jacob commented on patch set 3 V +1 CR +1 07/03/18, 08:10
Awesome! -
TYPO3com voted on patch set 3 V +1 07/03/18, 08:16 Completed build in 07m 29s on Tue, 3 Jul, 10:16 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25061
-
Karavas Aristeidis commented on patch set 3 V +1 CR +1 07/03/18, 09:41
> Patch Set 1: Verified-1 > > (2 comments) I think in general, a concrete example with images would help much more :) -
Sybille Peters commented on patch set 3 V +1 CR +1 07/03/18, 19:48
This is definitely an improvement. One issue I often have with the TYPO3 docuumentation: It sometimes jumps straight into the details without explaining the general concepts. Here, I would like to see an explanation: "What is a content element?". When do you add a custom content element, when do you use a plugin? But that is beyond the scope of this patch. -
Mathias Brodala voted on patch set 3 V +2 CR +2 07/04/18, 07:04
-
Mathias Brodala merged patch set 4 07/04/18, 07:04
-
Mathias Brodala commented on patch set 4 07/04/18, 07:04
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b1774d62e0d931164b7ee629e160c36afd5746bf
Index.rst:169