Review TYPO3_7-6 Merged

57457[BUGFIX] Properly check if there are open documents

Andreas Kienast CR +2 V +2 Easy +7 −4 updated 07/25/18, 22:04

Commit message

The toolbar item for open documents now properly checks whether there are
any open document to avoid actions on a null value. Additionally, the
arrays holding the state are now correctly initialized.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Grein +1
    • Michael Oehlhof +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Grein +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1214

  1. Andreas Kienast uploaded patch set 1 07/03/18, 12:47

  2. Andreas Kienast commented on patch set 1 07/03/18, 12:48

    Hint: The same bug was fixed nearly two years ago in master (now v8) in the scope of the fluidification of the toolbar. That's the reason why none of the fixes where backported to v7.
  3. Mathias Brodala updated the commit message in patch set 2 07/03/18, 12:53

  4. Mathias Brodala voted on patch set 2 CR +1 07/03/18, 12:54

  5. TYPO3com voted on patch set 1 V +1 07/03/18, 12:55 Completed build in 07m 30s on Tue, 3 Jul, 02:55 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1497

  6. TYPO3com voted on patch set 2 V +1 07/03/18, 13:01 Completed build in 07m 22s on Tue, 3 Jul, 03:01 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1498

  7. Michael Oehlhof voted on patch set 2 CR +1 07/03/18, 14:16

  8. Benni Mack commented on patch set 2 07/04/18, 06:51

    OpendocsToolbarItem.php:79

    afaik, you don't need list($this->openDocs, ), but instead list($this->openDocs) should be sufficient
  9. Mathias Brodala commented on patch set 2 07/04/18, 06:54

    OpendocsToolbarItem.php:79 Reply

    In fact this would be even simpler: $this->openDocs = $openDocs[0]; This is what I did for master, see OpenDocumentService::getOpenDocuments().
  10. Andreas Kienast commented on patch set 2 07/24/18, 06:39

    Sorry for the late feedback. In fact, I choose this coding style to have it in line with v8.
  11. Alexander Grein voted on patch set 2 V +1 CR +1 07/25/18, 14:58

  12. Christian Kuhn commented on patch set 2 07/25/18, 22:03

    confirmed issue on 7.6 if opendocs is loaded on php 7.2. confirmed the issue solves it. i'm ok with the rather ugly change for v7 to make that more in-sync with v8.
  13. Christian Kuhn voted on patch set 2 V +2 CR +2 07/25/18, 22:03

  14. Christian Kuhn merged patch set 3 07/25/18, 22:04