Review main Merged

57461[TASK] Refactor acceptance tests

Michael Bodnarchuk CR +2 V +2 Nightmare +1500 −1211 updated 07/07/18, 11:28

Commit message

typo3/testing-framework got a major release:
composer update typo3/testing-framework ^4.0

* codeception acceptance tests now live in a proper php namespace
* merged installation suites yml files into one
* installer tests are now one suite with different environment settings
* aligned with changes in typo3/testing-framework
* renamed Acceptance test suite to Backend test suite
* removed Admin/Editor steps, replaced with useExistingLogin('role')

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 55

Show 35 more files

Review log 2945

Show 1220 earlier messages
  1. Michael Bodnarchuk uploaded patch set 1 07/04/18, 15:08

  2. Christian Kuhn commented on patch set 1 CR -2 07/04/18, 15:13

    wip patch, will finish.
  3. Anja Leichsenring updated the commit message in patch set 2 07/04/18, 15:15

  4. TYPO3com voted on patch set 1 V -1 07/04/18, 15:17 Completed build in 08m 24s on Wed, 4 Jul, 05:17 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25079

  5. TYPO3com voted on patch set 2 V -1 07/04/18, 15:23 Completed build in 08m 04s on Wed, 4 Jul, 05:23 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25080

  6. Tymoteusz Motylewski commented on patch set 2 07/04/18, 15:31

    AbstractElementsBasicCest.php:35

    what is the reason/difference?
  7. Christian Kuhn commented on patch set 2 07/04/18, 16:27

    AbstractElementsBasicCest.php:35 Reply

    not fully finished: we'll refactor to use a true data provider here, see typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicInputCest.php

    Admin.php:22

    this class could be removed if we refactor the existing Cests a bit.
  8. Michael Bodnarchuk uploaded patch set 3 07/04/18, 16:36

  9. TYPO3com voted on patch set 3 V -1 07/04/18, 16:36 Completed build in 09s on Wed, 4 Jul, 06:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25082

  10. Oliver Klee commented on patch set 3 07/04/18, 16:52

    Typo: Reafctor -> Refactor
  11. Michael Bodnarchuk uploaded patch set 4 07/04/18, 22:03

  12. TYPO3com voted on patch set 4 V -1 07/04/18, 22:03 Completed build in 09s on Thu, 5 Jul, 12:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25100

  13. Josef Glatz updated the commit message in patch set 5 07/05/18, 05:25

  14. TYPO3com voted on patch set 5 V -1 07/05/18, 05:26 Completed build in 09s on Thu, 5 Jul, 07:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25101

  15. Christian Kuhn uploaded patch set 6 07/05/18, 18:33

  16. TYPO3com voted on patch set 6 V -1 07/05/18, 18:40 Completed build in 07m 42s on Thu, 5 Jul, 08:40 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25120

  17. Christian Kuhn uploaded patch set 7 07/05/18, 18:56

  18. Christian Kuhn uploaded patch set 8 07/05/18, 19:00

  19. TYPO3com voted on patch set 7 V -1 07/05/18, 19:05 Completed build in 08m 42s on Thu, 5 Jul, 09:05 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25121

  20. TYPO3com voted on patch set 8 V -1 07/05/18, 19:09 Completed build in 08m 09s on Thu, 5 Jul, 09:09 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25122

  1. Christian Kuhn uploaded patch set 9 07/05/18, 19:17

  2. TYPO3com voted on patch set 9 V -1 07/05/18, 19:18 Completed build in 08s on Thu, 5 Jul, 09:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25123

  3. Christian Kuhn uploaded patch set 10 07/05/18, 19:23

  4. TYPO3com voted on patch set 10 V -1 07/05/18, 19:31 Completed build in 08m 07s on Thu, 5 Jul, 09:31 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25124

  5. Christian Kuhn uploaded patch set 11 07/05/18, 23:42

  6. TYPO3com voted on patch set 11 V -1 07/05/18, 23:50 Completed build in 07m 52s on Fri, 6 Jul, 01:50 AM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25128

  7. Christian Kuhn uploaded patch set 12 07/05/18, 23:51

  8. Christian Kuhn uploaded patch set 13 07/05/18, 23:55

  9. TYPO3com voted on patch set 12 V -1 07/05/18, 23:56 Completed build in 04m 44s on Fri, 6 Jul, 01:56 AM Test Summary: 31324 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25129

  10. TYPO3com voted on patch set 13 V -1 07/05/18, 23:59 Completed build in 03m 03s on Fri, 6 Jul, 01:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25130

  11. Christian Kuhn uploaded patch set 14 07/06/18, 00:07

  12. Christian Kuhn commented on patch set 14 07/06/18, 00:08

    still WIP, but green on bamboo "testbed lolli" already :)
  13. TYPO3com voted on patch set 14 V -1 07/06/18, 00:16 Completed build in 08m 01s on Fri, 6 Jul, 02:16 AM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25131

  14. Tymoteusz Motylewski commented on patch set 14 07/06/18, 07:30

    CompareUserCest.php:46

    is it still needed after the change in Testing framework: https://github.com/TYPO3/testing-framework/commit/7460e69f8d595af94984debaee92e605abebb97b ?
  15. Christian Kuhn commented on patch set 14 07/06/18, 09:27

    CompareUserCest.php:46 Reply

    probably not.
  16. Oliver Klee wrote 07/06/18, 09:56

    Removed reviewer Oliver Klee.
  17. Christian Kuhn uploaded patch set 15 07/07/18, 09:01

  18. TYPO3com voted on patch set 15 V +1 07/07/18, 09:09 Completed build in 07m 45s on Sat, 7 Jul, 11:09 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25204

  19. Christian Kuhn commented on patch set 15 V +2 CR +2 07/07/18, 10:01

    i'll take the freedom to merge this since i deployed the plan update already and other bamboo runs will fail until this is merged.
  20. Christian Kuhn voted on patch set 15 V 0 CR 0 07/07/18, 10:02

  21. Christian Kuhn updated the commit message in patch set 16 07/07/18, 10:02

  22. TYPO3com voted on patch set 16 V +1 07/07/18, 10:11 Completed build in 08m 26s on Sat, 7 Jul, 12:11 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25205

  23. Christian Kuhn voted on patch set 16 V +2 CR +2 07/07/18, 10:15

  24. Christian Kuhn merged patch set 17 07/07/18, 10:15

  25. Tymoteusz Motylewski commented on patch set 17 07/07/18, 11:28

    Great! Thanks!