57461[TASK] Refactor acceptance tests
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
- TYPO3com +1 CI
Issues 1
Files 55
- Build/bamboo/src/main/java/core/AbstractCoreSpec.java+27 −19
- Build/Scripts/annotationChecker.php+2 −0
- typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/CompareUserCest.php2+8 −9
- typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/ListGroupCest.php+15 −13
- typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/ListUserCest.php+34 −35
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/GetExtensionsCest.php+13 −12
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+11 −10
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileMetaDataCest.php+6 −11
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/AbstractElementsBasicCest.phpnew+126 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/CategoryTreeCest.phprenamed+10 −9
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputCest.phpnew+386 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputDateCest.phpnew+319 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsGroupCest.phprenamed+23 −16
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/FalMetadataInheritanceCest.phprenamed+21 −14
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/Inline1nCest.phprenamed+21 −13
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/AbstractElementsBasicCest.php2deleted+0 −127
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicInputCest.phpdeleted+0 −354
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicInputDateCest.phpdeleted+0 −271
- typo3/sysext/core/Tests/Acceptance/Backend/General/ModuleMenuCest.php+9 −8
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php+15 −13
Show 35 more files
- typo3/sysext/core/Tests/Acceptance/Backend/Page/AddPageInPageModuleCest.php+9 −5
- typo3/sysext/core/Tests/Acceptance/Backend/Page/PageModuleCest.php+9 −5
- typo3/sysext/core/Tests/Acceptance/Backend/RecordList/SysNoteCest.php+8 −13
- typo3/sysext/core/Tests/Acceptance/Backend/Redirect/RedirectModuleCest.php+10 −11
- typo3/sysext/core/Tests/Acceptance/Backend/Scheduler/TasksCest.php+22 −21
- typo3/sysext/core/Tests/Acceptance/Backend/Template/TemplateCest.php+9 −8
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/BookmarkCest.php+21 −20
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/FlushCest.php+11 −10
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/HelpCest.php+11 −10
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/LogoCest.php+7 −6
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/ModuleMenuButtonCest.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/NavigationComponentTreeCest.php+9 −8
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php+12 −11
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/UsernameOnAvatarCest.php+6 −5
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.phprenamed+12 −7
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/IntroductionPackageCest.phprenamed+12 −7
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.phprenamed+12 −6
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/IntroductionPackageCest.phprenamed+12 −6
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.phprenamed+8 −4
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/IntroductionPackageCest.phprenamed+8 −4
- typo3/sysext/core/Tests/Acceptance/Support/Helper/ModalDialog.phpnew+35 −0
- typo3/sysext/core/Tests/Acceptance/Support/Helper/PageTree.phpnew+35 −0
- typo3/sysext/core/Tests/Acceptance/Support/BackendTester.phpnew+28 −0
- typo3/sysext/core/Tests/Acceptance/Support/InstallTester.phpnew+28 −0
- typo3/sysext/core/Tests/Acceptance/Backend.suite.ymlnew+38 −0
- typo3/sysext/core/Tests/Acceptance/Install.suite.ymlnew+43 −0
- typo3/sysext/core/Tests/Acceptance.suite.ymldeleted+0 −21
- typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.ymldeleted+0 −21
- typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.ymldeleted+0 −21
- typo3/sysext/core/Tests/AcceptanceInstallSqlite.suite.ymldeleted+0 −21
- typo3/sysext/core/Tests/codeception.ymlnew+13 −0
- typo3/sysext/core/composer.json+1 −1
- .gitignore+2 −0
- composer.json+1 −1
- composer.lock+13 −15
Review log 2945
Show 1220 earlier messages
-
Michael Bodnarchuk uploaded patch set 1 07/04/18, 15:08
-
Christian Kuhn commented on patch set 1 CR -2 07/04/18, 15:13
wip patch, will finish. -
Anja Leichsenring updated the commit message in patch set 2 07/04/18, 15:15
-
TYPO3com voted on patch set 1 V -1 07/04/18, 15:17 Completed build in 08m 24s on Wed, 4 Jul, 05:17 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25079
-
TYPO3com voted on patch set 2 V -1 07/04/18, 15:23 Completed build in 08m 04s on Wed, 4 Jul, 05:23 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25080
-
Tymoteusz Motylewski commented on patch set 2 07/04/18, 15:31
AbstractElementsBasicCest.php:35what is the reason/difference? -
Christian Kuhn commented on patch set 2 07/04/18, 16:27
AbstractElementsBasicCest.php:35Replynot fully finished: we'll refactor to use a true data provider here, see typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicInputCest.phpAdmin.php:22this class could be removed if we refactor the existing Cests a bit. -
Michael Bodnarchuk uploaded patch set 3 07/04/18, 16:36
-
TYPO3com voted on patch set 3 V -1 07/04/18, 16:36 Completed build in 09s on Wed, 4 Jul, 06:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25082
-
Oliver Klee commented on patch set 3 07/04/18, 16:52
Typo: Reafctor -> Refactor -
Michael Bodnarchuk uploaded patch set 4 07/04/18, 22:03
-
TYPO3com voted on patch set 4 V -1 07/04/18, 22:03 Completed build in 09s on Thu, 5 Jul, 12:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25100
-
Josef Glatz updated the commit message in patch set 5 07/05/18, 05:25
-
TYPO3com voted on patch set 5 V -1 07/05/18, 05:26 Completed build in 09s on Thu, 5 Jul, 07:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25101
-
Christian Kuhn uploaded patch set 6 07/05/18, 18:33
-
TYPO3com voted on patch set 6 V -1 07/05/18, 18:40 Completed build in 07m 42s on Thu, 5 Jul, 08:40 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25120
-
Christian Kuhn uploaded patch set 7 07/05/18, 18:56
-
Christian Kuhn uploaded patch set 8 07/05/18, 19:00
-
TYPO3com voted on patch set 7 V -1 07/05/18, 19:05 Completed build in 08m 42s on Thu, 5 Jul, 09:05 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25121
-
TYPO3com voted on patch set 8 V -1 07/05/18, 19:09 Completed build in 08m 09s on Thu, 5 Jul, 09:09 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25122
-
Christian Kuhn uploaded patch set 9 07/05/18, 19:17
-
TYPO3com voted on patch set 9 V -1 07/05/18, 19:18 Completed build in 08s on Thu, 5 Jul, 09:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25123
-
Christian Kuhn uploaded patch set 10 07/05/18, 19:23
-
TYPO3com voted on patch set 10 V -1 07/05/18, 19:31 Completed build in 08m 07s on Thu, 5 Jul, 09:31 PM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25124
-
Christian Kuhn uploaded patch set 11 07/05/18, 23:42
-
TYPO3com voted on patch set 11 V -1 07/05/18, 23:50 Completed build in 07m 52s on Fri, 6 Jul, 01:50 AM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25128
-
Christian Kuhn uploaded patch set 12 07/05/18, 23:51
-
Christian Kuhn uploaded patch set 13 07/05/18, 23:55
-
TYPO3com voted on patch set 12 V -1 07/05/18, 23:56 Completed build in 04m 44s on Fri, 6 Jul, 01:56 AM Test Summary: 31324 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25129
-
TYPO3com voted on patch set 13 V -1 07/05/18, 23:59 Completed build in 03m 03s on Fri, 6 Jul, 01:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25130
-
Christian Kuhn uploaded patch set 14 07/06/18, 00:07
-
Christian Kuhn commented on patch set 14 07/06/18, 00:08
still WIP, but green on bamboo "testbed lolli" already :) -
TYPO3com voted on patch set 14 V -1 07/06/18, 00:16 Completed build in 08m 01s on Fri, 6 Jul, 02:16 AM Test Summary: 32874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25131
-
Tymoteusz Motylewski commented on patch set 14 07/06/18, 07:30
CompareUserCest.php:46is it still needed after the change in Testing framework: https://github.com/TYPO3/testing-framework/commit/7460e69f8d595af94984debaee92e605abebb97b ? -
Christian Kuhn commented on patch set 14 07/06/18, 09:27
CompareUserCest.php:46Replyprobably not. -
Oliver Klee wrote 07/06/18, 09:56
Removed reviewer Oliver Klee. -
Christian Kuhn uploaded patch set 15 07/07/18, 09:01
-
TYPO3com voted on patch set 15 V +1 07/07/18, 09:09 Completed build in 07m 45s on Sat, 7 Jul, 11:09 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25204
-
Christian Kuhn commented on patch set 15 V +2 CR +2 07/07/18, 10:01
i'll take the freedom to merge this since i deployed the plan update already and other bamboo runs will fail until this is merged. -
Christian Kuhn voted on patch set 15 V 0 CR 0 07/07/18, 10:02
-
Christian Kuhn updated the commit message in patch set 16 07/07/18, 10:02
-
TYPO3com voted on patch set 16 V +1 07/07/18, 10:11 Completed build in 08m 26s on Sat, 7 Jul, 12:11 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25205
-
Christian Kuhn voted on patch set 16 V +2 CR +2 07/07/18, 10:15
-
Christian Kuhn merged patch set 17 07/07/18, 10:15
-
Tymoteusz Motylewski commented on patch set 17 07/07/18, 11:28
Great! Thanks!