57463[TASK] Replace misused in_array calls
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Andreas Kienast +1
- Jürgen Venne +1
-
Verified V +2
- Anja Leichsenring +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 25
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php1+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ArrayDimensionMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ArrayGlobalMatcher.php+1 −5
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ClassConstantMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ClassNameMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstantMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/FunctionCallMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallStaticMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcher.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyProtectedMatcher.php+1 −1
Show 5 more files
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/PropertyPublicMatcher.php+1 −1
- typo3/sysext/install/Classes/Service/LanguagePackService.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php+4 −1
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −1
Review log 811
-
Wouter Wolters uploaded patch set 1 07/04/18, 17:55
-
TYPO3com voted on patch set 1 V -1 07/04/18, 17:56 Completed build in 07s on Wed, 4 Jul, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25085
-
Wouter Wolters uploaded patch set 2 07/04/18, 17:57
-
TYPO3com voted on patch set 2 V +1 07/04/18, 18:05 Completed build in 07m 43s on Wed, 4 Jul, 08:05 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25086
-
Mathias Brodala commented on patch set 2 CR -1 07/05/18, 07:30
Please swap the equality condition operands.DatabaseIntegrityCheck.php:483Not agreed on Yoda conditions we have. ;-) -
Anja Leichsenring uploaded patch set 3 07/06/18, 18:37
-
Andreas Kienast voted on patch set 3 V +1 CR +1 07/06/18, 18:42
-
TYPO3com voted on patch set 3 V +1 07/06/18, 18:45 Completed build in 07m 47s on Fri, 6 Jul, 08:45 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25188
-
Jürgen Venne voted on patch set 3 CR +1 07/06/18, 19:04
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 07/06/18, 19:13
-
Anja Leichsenring merged patch set 4 07/06/18, 19:13