Review main Merged

57463[TASK] Replace misused in_array calls

Wouter Wolters CR +2 V +2 Normal +35 −36 updated 07/06/18, 19:13

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • Jürgen Venne +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 811

  1. Wouter Wolters uploaded patch set 1 07/04/18, 17:55

  2. TYPO3com voted on patch set 1 V -1 07/04/18, 17:56 Completed build in 07s on Wed, 4 Jul, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25085

  3. Wouter Wolters uploaded patch set 2 07/04/18, 17:57

  4. TYPO3com voted on patch set 2 V +1 07/04/18, 18:05 Completed build in 07m 43s on Wed, 4 Jul, 08:05 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25086

  5. Mathias Brodala commented on patch set 2 CR -1 07/05/18, 07:30

    Please swap the equality condition operands.

    DatabaseIntegrityCheck.php:483

    Not agreed on Yoda conditions we have. ;-)
  6. Anja Leichsenring uploaded patch set 3 07/06/18, 18:37

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 07/06/18, 18:42

  8. TYPO3com voted on patch set 3 V +1 07/06/18, 18:45 Completed build in 07m 47s on Fri, 6 Jul, 08:45 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25188

  9. Jürgen Venne voted on patch set 3 CR +1 07/06/18, 19:04

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/06/18, 19:13

  11. Anja Leichsenring merged patch set 4 07/06/18, 19:13