57464[TASK] Merge multiple isset calls to one statement
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 49
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php1+11 −13
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/FileTypeList.php+1 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php+1 −4
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseLanguageRows.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php+3 −9
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+5 −10
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php+1 −2
- typo3/sysext/backend/Classes/Form/NodeFactory.php+2 −2
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php+1 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −7
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+2 −3
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Migrations/TcaMigration.php1+19 −84
Show 29 more files
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Cli/Command.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php2+26 −25
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+1 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php1+1 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php3+5 −8
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php2+3 −7
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php2+2 −2
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php1+1 −1
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php1+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+3 −3
- typo3/sysext/frontend/Classes/ContentObject/LoadRegisterContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+1 −1
- typo3/sysext/install/Classes/Configuration/AbstractCustomPreset.php+1 −3
- typo3/sysext/install/Classes/ExtensionScanner/Php/MatcherFactory.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −1
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.php2+2 −6
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −3
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php1+2 −2
- typo3/sysext/rte_ckeditor/Classes/Form/Resolver/RichTextNodeResolver.php2+3 −8
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php1+1 −1
Review log 711
-
Wouter Wolters uploaded patch set 1 07/04/18, 18:04
-
TYPO3com voted on patch set 1 V -1 07/04/18, 18:04 Completed build in 17s on Wed, 4 Jul, 08:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25087
-
Wouter Wolters uploaded patch set 2 07/04/18, 18:04
-
TYPO3com voted on patch set 2 V +1 07/04/18, 18:12 Completed build in 07m 45s on Wed, 4 Jul, 08:12 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25088
-
Mathias Brodala commented on patch set 2 CR -1 07/05/18, 08:03
In general I would prefer if the isset() arguments would be on their own line to a) improve readability and b) reduce the diff for following changes.BackendModuleRepository.php:207This can be merged into a single check.FormProtectionFactory.php:142This should be reverted since the current version properly checks from the outside whereas the new version makes an assumption in between only to check the base for that assumption afterwards.Typo3DbBackend.php:599This can be dropped since it is covered by the following two isset() checks. BTW: why where these not merged?Typo3DbBackend.php:602The isset can be dropped here since it is checked one line above already.EmConfUtility.php:88This can be removed since it is covered by the following checks.EmConfUtility.php:99Same here.EmConfUtility.php:102Same here.SaveToDatabaseFinisher.php:222This looks very confusing and should be reordered to group the $elementValue checks and the other checks. BTW, the basic "$elementsConfiguration[$elementIdentifier]" check can be dropped since it is covered by the other checks.FormDefinition.php:495While technically working it does not make sense to check for an array key and only afterwards if the subject is an array at all. This should be reverted or rewritten e.g. using the null coalesce operator.AbstractRenderable.php:186Same here.FormDefinitionArrayConverter.php:96Same here. Also the is_int($key) check should come first.ContentObjectRenderer.php:1120This does not make sense since the current version ensures that the $layoutKey is not empty before using it as array key.ContentObjectRenderer.php:1723Same here.ExtensionConfigurationService.php:226This can be dropped.BrowseLinksController.php:223Indentation is off here.RichTextNodeResolver.php:55This can be simplified a bit using the null coalesce operator. -
Wouter Wolters uploaded patch set 3 07/23/18, 19:13
-
TYPO3com voted on patch set 3 V -1 07/23/18, 19:14 Completed build in 18s on Mon, 23 Jul, 09:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25688
-
Wouter Wolters uploaded patch set 4 07/23/18, 19:19
-
TYPO3com voted on patch set 4 V +1 07/23/18, 19:29 Completed build in 09m 21s on Mon, 23 Jul, 09:29 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25690
-
Susi Moog commented on patch set 4 CR -1 07/29/18, 13:36
BackendUserAuthentication.php:601why are these not merged?BackendUserAuthentication.php:2722accessing "user" potentially on a non-object now as the instanceof check isn't done before.TcaMigration.php:1999braces missing, the evaluation of the condition now changed as the last part (OR) is now an OR for everything instead of just for enableRichtextDateTimeConverter.php:181why keep the year separate?SaveToDatabaseFinisher.php:223recheck this condition please, I guess it's wrong now (should be semantically: if value is null or empty and skipIfValueIsEmpty is enabled, continue) - in this case for readability / following the logic I think it makes sense to keep the order (value check, then isset // skip)AbstractRenderable.php:209is_array will now throw a notice if $validatorIdentifier is not set.ExtensionConfigurationService.php:222results in "undefined index" subcat_name (as the isset only takes care of the notice on subCategories, not of configurationOption)RichTextNodeResolver.php:54the comment doesn't make sense anymore at this place. either get back the old comments and add them to the according places or remove fully.GridDataService.php:480can these be merged, too? -
Benni Mack abandoned the change 10/28/18, 16:13
abandoned, we'll go with another take on this.