Review main Merged

57466[TASK] Replace substr(...) with strpos(...)

Wouter Wolters CR +2 V +2 Normal +93 −93 updated 09/18/18, 18:45

Commit message

strpos will use only CPU resources, substr also needs memory allocation.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 51

Show 31 more files

Review log 1926

Show 1 earlier messages
  1. Wouter Wolters uploaded patch set 1 07/04/18, 18:14

  1. TYPO3com voted on patch set 1 V -1 07/04/18, 18:15 Completed build in 16s on Wed, 4 Jul, 08:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25091

  2. Wouter Wolters uploaded patch set 2 07/04/18, 18:16

  3. TYPO3com voted on patch set 2 V +1 07/04/18, 18:23 Completed build in 07m 31s on Wed, 4 Jul, 08:23 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25092

  4. Mathias Brodala commented on patch set 2 CR -1 07/05/18, 07:34

    Please swap the equality check operators.
  5. Wouter Wolters commented on patch set 2 CR -1 07/09/18, 11:31

    will do once the new release of the plugin I used is out. YODA is the default and can't be changed at the moment.
  6. Wouter Wolters uploaded patch set 3 07/23/18, 18:39

  7. TYPO3com voted on patch set 3 V -1 07/23/18, 18:39 Completed build in 26s on Mon, 23 Jul, 08:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25683

  8. Wouter Wolters uploaded patch set 4 07/23/18, 19:16

  9. TYPO3com voted on patch set 4 V +1 07/23/18, 19:23 Completed build in 07m 08s on Mon, 23 Jul, 09:23 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25689

  10. Mathias Brodala commented on patch set 4 07/24/18, 08:40

    AddController.php:161

    For consistency we can probably use strpos/strrpos here.

    ListController.php:127

    Same here.

    YamlFileLoader.php:154

    Same here.

    RteHtmlParser.php:998

    Same here.

    RteHtmlParser.php:999

    And here.

    RteHtmlParser.php:1135

    This looks off.
  11. Mona Muzaffar uploaded patch set 5 08/10/18, 16:45

  12. Mona Muzaffar commented on patch set 5 08/10/18, 16:45

    only solved the merged conflict
  13. TYPO3com voted on patch set 5 V +1 08/10/18, 16:51 Completed build in 06m 34s on Fri, 10 Aug, 06:51 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26371

  14. Tymoteusz Motylewski commented on patch set 5 CR -1 08/14/18, 11:38

    Comments from Mathias are still valid
  15. Wouter Wolters commented on patch set 5 08/16/18, 22:29

    @mathias as this change is automatically generated I want to prevent more changes to happen and get in a rebase war. If you think it is worth the effort to fix more stuff I opt for doing that in further patches. After Feature Freeze there will be a lot more cleanups which I don't want to rebase all the time.
  16. Mathias Brodala commented on patch set 6 08/17/18, 07:12

    Published edit on patch set 5.
  17. Mathias Brodala commented on patch set 6 08/17/18, 07:13

    > @mathias as this change is automatically generated I want to > prevent more changes to happen and get in a rebase war. If you > think it is worth the effort to fix more stuff I opt for doing that > in further patches. After Feature Freeze there will be a lot more > cleanups which I don't want to rebase all the time. I understand that. I just fixed the only weirdly formatted location.
  18. TYPO3com voted on patch set 6 V +1 08/17/18, 07:19 Completed build in 06m 30s on Fri, 17 Aug, 09:19 AM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26709

  19. Jan Helke voted on patch set 6 V +1 CR +1 08/17/18, 08:38

  20. Jigal van Hemert uploaded patch set 7 09/02/18, 08:44

  21. Jigal van Hemert commented on patch set 7 V +1 CR +1 09/02/18, 08:51

    Just resolved the merge conflict.
  22. TYPO3com voted on patch set 7 V +1 09/02/18, 08:54 Completed build in 09m 04s on Sun, 2 Sep, 10:54 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27533

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 09/02/18, 10:48

  24. Christian Kuhn merged patch set 8 09/02/18, 10:48

  25. Andreas Kienast commented on patch set 8 09/18/18, 18:45

    ActionTask.php:622 Unresolved

    Regression: $prefix must not be empty, otherwise strpos() fails! See https://review.typo3.org/c/58320/