57466[TASK] Replace substr(...) with strpos(...)
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jigal van Hemert +1
-
Verified V +2
- Christian Kuhn +2
- Jigal van Hemert +1
- TYPO3com +1 CI
Issues 1
Files 51
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php1+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/ListController.php1+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+2 −2
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+2 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php+3 −3
- typo3/sysext/core/Classes/Cache/Backend/PdoBackend.php+2 −2
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+1 −1
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php+1 −1
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php1+1 −1
- typo3/sysext/core/Classes/Database/PdoHelper.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+7 −7
- typo3/sysext/core/Classes/Database/QueryView.php+5 −5
- typo3/sysext/core/Classes/Html/RteHtmlParser.php3+5 −5
Show 31 more files
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+4 −4
- typo3/sysext/core/Classes/Package/PackageManager.php+1 −1
- typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Classes/Utility/ClassNamingUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −2
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Repository.php+3 −3
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+4 −4
- typo3/sysext/extbase/Classes/Service/ImageService.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+4 −4
- typo3/sysext/indexed_search/Classes/Indexer.php+3 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+1 −1
- typo3/sysext/install/Classes/Controller/UpgradeController.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −2
- typo3/sysext/rsaauth/Classes/Backend/CommandLineBackend.php+2 −2
- typo3/sysext/rsaauth/Classes/BackendWarnings.php+1 −1
- typo3/sysext/rsaauth/Classes/RsaAuthService.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/sys_action/Classes/ActionTask.php1+2 −2
Review log 1926
Show 1 earlier messages
-
Wouter Wolters uploaded patch set 1 07/04/18, 18:14
-
TYPO3com voted on patch set 1 V -1 07/04/18, 18:15 Completed build in 16s on Wed, 4 Jul, 08:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25091
-
Wouter Wolters uploaded patch set 2 07/04/18, 18:16
-
TYPO3com voted on patch set 2 V +1 07/04/18, 18:23 Completed build in 07m 31s on Wed, 4 Jul, 08:23 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25092
-
Mathias Brodala commented on patch set 2 CR -1 07/05/18, 07:34
Please swap the equality check operators. -
Wouter Wolters commented on patch set 2 CR -1 07/09/18, 11:31
will do once the new release of the plugin I used is out. YODA is the default and can't be changed at the moment. -
Wouter Wolters uploaded patch set 3 07/23/18, 18:39
-
TYPO3com voted on patch set 3 V -1 07/23/18, 18:39 Completed build in 26s on Mon, 23 Jul, 08:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25683
-
Wouter Wolters uploaded patch set 4 07/23/18, 19:16
-
TYPO3com voted on patch set 4 V +1 07/23/18, 19:23 Completed build in 07m 08s on Mon, 23 Jul, 09:23 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25689
-
Mathias Brodala commented on patch set 4 07/24/18, 08:40
AddController.php:161For consistency we can probably use strpos/strrpos here.ListController.php:127Same here.YamlFileLoader.php:154Same here.RteHtmlParser.php:998Same here.RteHtmlParser.php:999And here.RteHtmlParser.php:1135This looks off. -
Mona Muzaffar uploaded patch set 5 08/10/18, 16:45
-
Mona Muzaffar commented on patch set 5 08/10/18, 16:45
only solved the merged conflict -
TYPO3com voted on patch set 5 V +1 08/10/18, 16:51 Completed build in 06m 34s on Fri, 10 Aug, 06:51 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26371
-
Tymoteusz Motylewski commented on patch set 5 CR -1 08/14/18, 11:38
Comments from Mathias are still valid -
Wouter Wolters commented on patch set 5 08/16/18, 22:29
@mathias as this change is automatically generated I want to prevent more changes to happen and get in a rebase war. If you think it is worth the effort to fix more stuff I opt for doing that in further patches. After Feature Freeze there will be a lot more cleanups which I don't want to rebase all the time. -
Mathias Brodala commented on patch set 6 08/17/18, 07:12
Published edit on patch set 5. -
Mathias Brodala commented on patch set 6 08/17/18, 07:13
> @mathias as this change is automatically generated I want to > prevent more changes to happen and get in a rebase war. If you > think it is worth the effort to fix more stuff I opt for doing that > in further patches. After Feature Freeze there will be a lot more > cleanups which I don't want to rebase all the time. I understand that. I just fixed the only weirdly formatted location. -
TYPO3com voted on patch set 6 V +1 08/17/18, 07:19 Completed build in 06m 30s on Fri, 17 Aug, 09:19 AM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26709
-
Jan Helke voted on patch set 6 V +1 CR +1 08/17/18, 08:38
-
Jigal van Hemert uploaded patch set 7 09/02/18, 08:44
-
Jigal van Hemert commented on patch set 7 V +1 CR +1 09/02/18, 08:51
Just resolved the merge conflict. -
TYPO3com voted on patch set 7 V +1 09/02/18, 08:54 Completed build in 09m 04s on Sun, 2 Sep, 10:54 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27533
-
Christian Kuhn voted on patch set 7 V +2 CR +2 09/02/18, 10:48
-
Christian Kuhn merged patch set 8 09/02/18, 10:48
-
Andreas Kienast commented on patch set 8 09/18/18, 18:45
ActionTask.php:622UnresolvedRegression: $prefix must not be empty, otherwise strpos() fails! See https://review.typo3.org/c/58320/