Review main Abandoned

57467[TASK] Merge multiple unset calls to one call

Wouter Wolters CR 0 V 0 Normal +70 −138 updated 10/28/18, 11:37

Commit message

Use shorthand substr if possible

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 35

Show 15 more files

Review log 1014

  1. Wouter Wolters uploaded patch set 1 07/04/18, 18:31

  2. Wouter Wolters updated the commit message in patch set 2 07/04/18, 18:33

  3. TYPO3com voted on patch set 1 V +1 07/04/18, 18:39 Completed build in 08m 22s on Wed, 4 Jul, 08:39 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25093

  4. TYPO3com voted on patch set 2 V +1 07/04/18, 18:42 Completed build in 09m 53s on Wed, 4 Jul, 08:42 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25094

  5. Łukasz Uznański commented on patch set 2 07/04/18, 19:09

    Bootstrap.php:758

    is this comment still required?

    RelationHandler.php:750

    I think these comments should be merged to one
  6. Mathias Brodala commented on patch set 2 07/05/18, 07:35

    TcaTypesShowitem.php:71

    Please at least put these on separate lines to a) keep it readable and b) reduce the diff for future changes.
  7. Jörg Bösche uploaded patch set 3 07/18/18, 07:02

  8. TYPO3com voted on patch set 3 V +1 07/18/18, 07:11 Completed build in 08m 57s on Wed, 18 Jul, 09:11 AM Test Summary: 33357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25516

  9. Stefan Neufeind commented on patch set 3 07/18/18, 08:50

    That substr-change feels wrong in there imho. And while having multiple unsets in one call, maybe do we want them to be in separate lines instead of one long? But technically it looks okay to me.
  10. Oliver Klee commented on patch set 3 07/18/18, 17:39

    TcaTypesShowitem.php:69

    This should not be a PHPDoc comment (with two asterisks), but a comment with /* or //.
  11. Jörg Bösche uploaded patch set 4 07/20/18, 08:04

  12. TYPO3com voted on patch set 4 V +1 07/20/18, 08:12 Completed build in 07m 25s on Fri, 20 Jul, 10:12 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25595

  13. Christian Kuhn commented on patch set 4 09/16/18, 22:56

    wouter :) any chance to finish this cleanup and bring it through before it conflicts again?
  14. Benni Mack abandoned the change 10/28/18, 11:37

    abandoned for now