Review main Merged

57468[TASK] Replace gettype calls type-specific checks

Wouter Wolters CR +2 V +2 Easy +4 −4 updated 07/20/18, 06:42

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1316

  1. Wouter Wolters uploaded patch set 1 07/04/18, 18:47

  2. TYPO3com voted on patch set 1 V +1 07/04/18, 18:55 Completed build in 07m 54s on Wed, 4 Jul, 08:55 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25095

  3. Andreas Kienast voted on patch set 1 CR +1 07/04/18, 19:25

  4. Oliver Klee voted on patch set 1 CR +1 07/05/18, 06:53

  5. Mathias Brodala commented on patch set 1 07/05/18, 07:37

    ErrorController.php:147

    Interesting how the old code never checked for the actual value, so boolean "false" would also be true. Should we fix this?

    TypoScriptFrontendController.php:1971

    Same here.
  6. Wouter Wolters commented on patch set 1 07/18/18, 19:44

    This patch is just a cleanup, I would do the backport separatly to make that more visible
  7. Timo Poppinga voted on patch set 1 V +1 CR +1 07/19/18, 22:39

  8. Andreas Kienast rebased onto patch set 2 07/20/18, 06:03

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 07/20/18, 06:04

  10. Andreas Kienast uploaded patch set 3 07/20/18, 06:04

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 07/20/18, 06:04

  12. TYPO3com voted on patch set 2 V +1 07/20/18, 06:13 Completed build in 09m 15s on Fri, 20 Jul, 08:13 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25591

  13. TYPO3com voted on patch set 3 V +1 07/20/18, 06:18 Completed build in 13m 46s on Fri, 20 Jul, 08:18 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25592

  14. Jörg Bösche voted on patch set 3 V +1 CR +1 07/20/18, 06:26

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 07/20/18, 06:42

  16. Andreas Kienast merged patch set 4 07/20/18, 06:42