Review main Abandoned

57483[BUGFIX] Ensure that non-admin BE user cannot see root page tree in BE

Presedo Roberto CR 0 V 0 Easy +15 −0 updated 09/30/18, 18:08

Commit message

This bug fix adds a check to ensure non-admin users can see root page
tree.

Allowing non-admin BE users to see root page 0 is not possible since
you cannot select the root page as mount in BE user groups.
If, for some strange reasons, 0 is set in the db_mountpoints settings
of a BE user, this patch ensures thats the BE user is not able to see
the root page tree anyway.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1014

  1. Presedo Roberto uploaded patch set 1 07/06/18, 13:56

  2. TYPO3com voted on patch set 1 V -1 07/06/18, 13:58 Completed build in 01m 55s on Fri, 6 Jul, 03:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25166

  3. Presedo Roberto rebased onto patch set 2 07/08/18, 11:43

  4. TYPO3com voted on patch set 2 V -1 07/08/18, 11:43 Completed build in 08s on Sun, 8 Jul, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25224

  5. Jigal van Hemert commented on patch set 2 CR -1 07/08/18, 21:29

    Hi Roberto, Good to see your patches coming after coding night at the Dev Days! The comments in the code are quite short, not to be rude, but just to focus on the code. If you change the code use the amend option for the git commit command and always leave the Change-Id line intact (Gerrit will know then that different pushed changes belong together). Had to vote -1 because the code needs some changes. If you push a new version that vote is automatically removed.

    BackendUserAuthentication.php:1314

    The curly brace must be placed at a new line.

    BackendUserAuthentication.php:1316

    Use single quote please.

    BackendUserAuthentication.php:1322

    The array was already unique (in line 1317), also use single quotes please.

    BackendUserAuthentication.php:1323

    The whole foreach loop can be replaced by a single array_filter() call: $currentWebMounts = array_unique(GeneralUtility::intExplode(',', $this->dataLists['webmount_list'])); $this->dataLists['webmount_list'] = implode(',', array_filter($currentWebMounts)); The empty callback in array_filter() will remove all values that evaluate to false (e.g. integer 0).
  6. Francois Suter uploaded patch set 3 09/10/18, 08:57

  7. TYPO3com voted on patch set 3 V -1 09/10/18, 08:59 Completed build in 22s on Mon, 10 Sep, 10:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27933

  8. Francois Suter uploaded patch set 4 09/10/18, 09:08

  9. TYPO3com voted on patch set 4 V +1 09/10/18, 09:20 Completed build in 11m 50s on Mon, 10 Sep, 11:20 AM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27934

  10. Presedo Roberto voted on patch set 4 V +1 CR +1 09/10/18, 09:24

  11. Frank Nägler commented on patch set 4 CR -1 09/14/18, 13:25

    on it
  12. Frank Nägler commented on patch set 4 CR -2 09/14/18, 13:48

    After a short discussion with other people we will not fix this in the core. The interface does not allow this combination and the system reject a request for unauthorized user as described in the issue. The core is not responsible to handle and fix broken records, which ware created by third party code.
  13. Anja Leichsenring commented on patch set 4 09/19/18, 08:58

    > Patch Set 4: Code-Review-2 > > After a short discussion with other people we will not fix this in the core. then please abandon
  14. Jigal van Hemert abandoned the change 09/30/18, 18:08

    See remark by Frank.