Review main Merged

57489[BUGFIX] Use filename with extension for copy to temp test

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 07/31/18, 18:06

Commit message

Since the extension will be added to the temporary file name there
will be an error in Windows if the file name has no extension.
Windows will not create files with a name ending with a dot.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Jigal van Hemert uploaded patch set 1 07/06/18, 17:25

  2. TYPO3com voted on patch set 1 V +1 07/06/18, 17:33 Completed build in 07m 29s on Fri, 6 Jul, 07:33 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25182

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/06/18, 18:55

  4. Jigal van Hemert updated the commit message in patch set 2 07/07/18, 06:38

  5. TYPO3com voted on patch set 2 V +1 07/07/18, 06:46 Completed build in 07m 42s on Sat, 7 Jul, 08:46 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25203

  6. Jörg Bösche voted on patch set 2 CR +1 07/31/18, 12:20

  7. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 07/31/18, 12:21

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 07/31/18, 18:06

  9. Wouter Wolters merged patch set 3 07/31/18, 18:06

  10. Wouter Wolters commented on patch set 3 07/31/18, 18:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3739831dbc7126923ae8ebaf466b1084ffa82272