Review TYPO3_8-7 Merged

57491[BUGFIX] Check for exceptions instead of number of affected rows

Anja Leichsenring CR +2 V +2 Easy +13 −8 updated 07/06/18, 19:26

Commit message

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 510

  1. Anja Leichsenring commented on patch set 1 07/06/18, 19:00

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 07/06/18, 19:00 Completed build in 08s on Fri, 6 Jul, 09:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2677

  3. TYPO3com commented on patch set 1 07/06/18, 19:02 Completed build in 18s on Fri, 6 Jul, 09:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2677

  4. Anja Leichsenring rebased onto patch set 2 07/06/18, 19:04

  5. TYPO3com commented on patch set 2 07/06/18, 19:04 Completed build in 09s on Fri, 6 Jul, 09:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2678

  6. Anja Leichsenring rebased onto patch set 3 07/06/18, 19:09

  7. TYPO3com commented on patch set 3 07/06/18, 19:24 Completed build in 15m 12s on Fri, 6 Jul, 09:24 PM Test Summary: 1 of 58842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2682

  8. TYPO3com voted on patch set 3 V +1 07/06/18, 19:25 Completed build in 31m 25s on Fri, 6 Jul, 09:25 PM Test Summary: 58440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2682

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/06/18, 19:26

  10. Anja Leichsenring merged patch set 4 07/06/18, 19:26