Review main Abandoned

57497[BUGFIX] Create page via context menu on root page

Guido Schmechel CR 0 V 0 Easy +7 −3 updated 10/28/18, 14:55

Commit message

With all permissions on a page which is marked as root page,
now the editor can create a page on all levels via context menu.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 68

  1. Guido Schmechel uploaded patch set 1 07/07/18, 15:36

  2. TYPO3com voted on patch set 1 V -1 07/07/18, 15:44 Completed build in 07m 34s on Sat, 7 Jul, 05:44 PM Test Summary: 363 of 33131 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25211

  3. Guido Schmechel updated the commit message in patch set 2 07/07/18, 16:09

  4. TYPO3com voted on patch set 2 V -1 07/07/18, 16:16 Completed build in 07m 40s on Sat, 7 Jul, 06:16 PM Test Summary: 363 of 33131 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25213

  5. Riccardo De Contardi commented on patch set 2 08/01/18, 19:24

    after the patch the pages are created as children of the selected pages. Is this correct?
  6. Tymoteusz Motylewski commented on patch set 2 CR -1 08/04/18, 12:34

    DataHandler.php:1042

    $pid_value is <0 when we're creating a record after a record with uid === $pid_value. If $pid_value is > 0 it mean an uid of the page. So we can't just do abs, because this will make TYPO3 treat that some record uid (like tt_content) as if it was a PID.
  7. Guido Schmechel commented on patch set 2 08/11/18, 09:32

    OK, pity :-( Unfortunately, then i have no idea how to fix this.
  8. Benni Mack abandoned the change 10/28/18, 14:55