Review main Merged

57501[BUGFIX] Use same line endings in test as in function

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 08/07/18, 12:12

Commit message

In CommandTest::testGetDescription() now also LF is used as line ending,
just as in the tested function.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jörg Bösche +1
  • Verified V +2
    • Markus Klein +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Jigal van Hemert uploaded patch set 1 07/08/18, 09:43

  2. TYPO3com voted on patch set 1 V -1 07/08/18, 09:43 Completed build in 08s on Sun, 8 Jul, 11:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25223

  3. Jigal van Hemert rebased onto patch set 2 07/14/18, 21:27

  4. TYPO3com voted on patch set 2 V +1 07/14/18, 21:34 Completed build in 07m 16s on Sat, 14 Jul, 11:34 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25425

  5. Jörg Bösche voted on patch set 2 V +1 CR +1 07/14/18, 22:11

  6. Markus Klein voted on patch set 2 V +2 CR +2 07/14/18, 22:35

  7. Markus Klein merged patch set 3 07/14/18, 22:35

  8. Markus Klein commented on patch set 3 07/14/18, 22:51

    @Jigal: There is no equivalent test in 8.7!?
  9. Jigal van Hemert commented on patch set 3 07/16/18, 18:23

    > Patch Set 3: > > @Jigal: There is no equivalent test in 8.7!? @Markus: You're right! The test file is there, but the test itself is missing. I'll put a note in the forge issue.
  10. Oliver Hader commented on patch set 3 08/07/18, 12:12

    NO backport