Review main Merged

57512[BUGFIX] Remove superfluous Doctrine restriction check

Benni Mack CR +2 V +2 Easy +0 −4 updated 07/09/18, 11:26

Commit message

Similar to https://review.typo3.org/#/c/57434/
the check for TSFE->showHiddenRecords is unneeded
as the RestrictionContainer evaluates this information
(now done via aspects) directly anyway.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Benni Mack uploaded patch set 1 07/09/18, 10:39

  2. TYPO3com voted on patch set 1 V -1 07/09/18, 10:39 Completed build in 09s on Mon, 9 Jul, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25243

  3. Benni Mack updated the commit message in patch set 2 07/09/18, 10:40

  4. TYPO3com voted on patch set 2 V -1 07/09/18, 10:40 Completed build in 07s on Mon, 9 Jul, 12:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25244

  5. Benni Mack uploaded patch set 3 07/09/18, 10:41

  6. TYPO3com voted on patch set 3 V +1 07/09/18, 10:49 Completed build in 08m 22s on Mon, 9 Jul, 12:49 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25245

  7. Susi Moog voted on patch set 3 V +1 CR +1 07/09/18, 10:50

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 07/09/18, 11:26

  9. Christian Kuhn merged patch set 4 07/09/18, 11:26