Review main Merged

57513[TASK] Simplify and clean up error log system information

Helmut Hummel CR +2 V +2 Normal +32 −36 updated 07/09/18, 13:24

Commit message

Remove inheritance from abstract log module

Inheritance was used only to be able to get the time
from which to start to look for errors. This however never
really worked, because the constraint only had a startTimestamp
value set, if the user selected a custom time frame when viewing the log.

Therefore we can just assume errors have not been seen, unless
they are confirmed through the system information toolbar.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Helmut Hummel +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Helmut Hummel uploaded patch set 1 07/09/18, 10:59

  2. TYPO3com voted on patch set 1 V +1 07/09/18, 11:06 Completed build in 07m 08s on Mon, 9 Jul, 01:06 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25246

  3. Andreas Kienast voted on patch set 1 CR +1 07/09/18, 12:02

  4. Benni Mack voted on patch set 1 V +1 CR +2 07/09/18, 12:17

  5. Helmut Hummel voted on patch set 1 V +2 07/09/18, 13:24

  6. Helmut Hummel voted on patch set 1 CR +2 07/09/18, 13:24

  7. Helmut Hummel merged patch set 2 07/09/18, 13:24