Review TYPO3_7-6 Merged

57517[BUGFIX] Show query on static SQL data import

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 08/10/18, 16:53

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Mathias Brodala commented on patch set 1 07/09/18, 13:51

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/09/18, 13:59 Completed build in 08m 07s on Mon, 9 Jul, 03:59 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1504

  3. Mathias Brodala voted on patch set 1 CR +1 07/09/18, 14:02

  4. Björn Jacob commented on patch set 1 07/10/18, 05:34

    Please improve the commit message. It is not "sting" but "string. "The function importStaticSql() uses the variable $string, but only $query is set."
  5. Mathias Brodala updated the commit message in patch set 2 07/10/18, 07:07

  6. TYPO3com voted on patch set 2 V +1 07/10/18, 07:14 Completed build in 07m 09s on Tue, 10 Jul, 09:14 AM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1506

  7. Mona Muzaffar voted on patch set 2 CR +1 08/10/18, 15:04

  8. Mona Muzaffar voted on patch set 2 V +1 08/10/18, 16:48

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/10/18, 16:53

  10. Anja Leichsenring merged patch set 3 08/10/18, 16:53