Review main Merged

57520[BUGFIX] Only use SaltedHashingMethods marked as available

Oliver Hader CR +2 V +2 Easy +1 −1 updated 07/19/18, 07:21

Commit message

When determining the SaltedHashingMethod of a salted hash check only
SaltedHashingMethods which are marked as available.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Xavier Perseguers +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2125

  1. Oliver Hader uploaded patch set 1 07/09/18, 20:35

  2. TYPO3com voted on patch set 1 V +1 07/09/18, 20:43 Completed build in 07m 43s on Mon, 9 Jul, 10:43 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25266

  3. Mathias Brodala updated the commit message in patch set 2 07/10/18, 07:04

  4. TYPO3com voted on patch set 2 V +1 07/10/18, 07:11 Completed build in 07m 01s on Tue, 10 Jul, 09:11 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25268

  5. Andreas Kienast voted on patch set 2 CR +1 07/10/18, 07:24

  6. Susi Moog voted on patch set 2 CR +1 07/10/18, 10:01

  7. Stephan Großberndt commented on patch set 3 07/10/18, 12:19

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 07/10/18, 12:26 Completed build in 07m 10s on Tue, 10 Jul, 02:26 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25274

  9. Xavier Perseguers voted on patch set 3 CR +1 07/10/18, 12:42

  10. Stefan Neufeind voted on patch set 3 CR +1 07/10/18, 19:05

  11. Andreas Kienast voted on patch set 3 CR +1 07/11/18, 06:42

  12. Georg Ringer commented on patch set 3 V +1 CR +1 07/11/18, 07:11

    calling the isavailable method would be also a good idea for 8.7?
  13. Stephan Großberndt updated the commit message in patch set 4 07/11/18, 08:11

  14. Stephan Großberndt commented on patch set 4 CR +1 07/11/18, 08:13

  15. Xavier Perseguers voted on patch set 4 CR +1 07/11/18, 08:13

  16. TYPO3com voted on patch set 4 V +1 07/11/18, 08:18 Completed build in 06m 40s on Wed, 11 Jul, 10:18 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25285

  17. Andreas Kienast voted on patch set 4 CR +1 07/11/18, 08:26

  18. Georg Ringer voted on patch set 4 V +1 CR +1 07/11/18, 08:54

  19. Stefan Neufeind voted on patch set 4 CR +1 07/11/18, 09:00

  20. Christian Kuhn commented on patch set 4 07/18/18, 20:50

    in general that looks like a good idea and a quick solution to the argon issue in v9, i did not follow the code path entirely, yet, though. later, i would like to have an install tool preset to select the best matching salt algo. that is more work however and i currently have other tasks with higher priority. so if we're sure that patch is ok, it would be fine with me.
  21. Christian Kuhn commented on patch set 4 07/18/18, 20:52

    not that patch is not strictly needed for v8 - the default phpass (iirc) is always available in v8 and argon has been added to master only. so to stay on the safe side, the v8 backport could probably be left out without problems.
  22. Wouter Wolters voted on patch set 4 CR +1 07/18/18, 20:52

  23. Oliver Hader commented on patch set 4 07/19/18, 07:06

    Initially I just handed in that patch for master and then it got extended for 8.7 as well. Since hashing methods are configured in a generic way using $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods'], having the check as well in 8.7 makes sense to me - since it's not only limited to Argon2i.
  24. Stefan Neufeind voted on patch set 4 V +2 CR +2 07/19/18, 07:21

  25. Stefan Neufeind merged patch set 5 07/19/18, 07:21