Review main Merged

57526[BUGFIX] Streamline backend module menu and viewport initialization

Oliver Hader CR +2 V +2 Easy +4 −6 updated 07/18/18, 17:35

Commit message

ModuleMenu and Viewport initialization need to be defered to ensure
that DOM is available in order to apply further behavior in mentioned
client implementation.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Kienast +1
    • Jigal van Hemert +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 67

  1. Oliver Hader uploaded patch set 1 07/10/18, 10:46

  2. TYPO3com voted on patch set 1 V +1 07/10/18, 10:54 Completed build in 08m 23s on Tue, 10 Jul, 12:54 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25273

  3. Andreas Kienast voted on patch set 1 CR +1 07/10/18, 11:15

  4. Andreas Kienast commented on patch set 1 V +1 07/10/18, 11:47

    I'm not able to reproduce the issue, but the code makes sense to me.
  5. Jigal van Hemert voted on patch set 1 CR +1 07/10/18, 19:23

  6. Frank Nägler voted on patch set 1 V +2 CR +2 07/18/18, 17:35

  7. Frank Nägler merged patch set 2 07/18/18, 17:35