Review TYPO3_8-7 Merged

57527[BUGFIX] Streamline backend module menu and viewport initialization

Oliver Hader CR +2 V +2 Easy +5 −3 updated 07/18/18, 18:42

Commit message

ModuleMenu and Viewport initialization need to be defered to ensure
that DOM is available in order to apply further behavior in mentioned
client implementation. Besides that, property 'iframe' is extended by
a JavaScript getter - otherwise directly assigning another property of
an undefined object will fail.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 07/10/18, 10:47

  2. TYPO3com voted on patch set 1 V +1 07/10/18, 10:56 Completed build in 08m 23s on Tue, 10 Jul, 12:56 PM Test Summary: 58434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2689

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/10/18, 16:00

  4. Frank Nägler commented on patch set 1 CR +1 07/18/18, 17:42

    Viewport.js:127

    looks very funny :) but nice
  5. Frank Nägler voted on patch set 1 V +2 CR +2 07/18/18, 18:42

  6. Frank Nägler merged patch set 2 07/18/18, 18:42