Review main Merged

57530[BUGFIX] LanguagePackCommand: Hide progress output by default

Josef Glatz CR +2 V +2 Easy +14 −5 updated 07/13/18, 07:49

Commit message

Show progress bar only if verbosity level is set. The default output
of this command is disabled by default to limit the amount of e-mails
sent by the TYPO3 scheduler (which normally makes only sense, if any
error occurs).

You can activate the output if you set the verbosity while calling the
command ("-v" option).

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Alexander Grein +1
    • Benni Mack +1
  • Verified V +2
    • Mathias Brodala +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2736

Show 1011 earlier messages
  1. Josef Glatz uploaded patch set 1 07/11/18, 08:57

  2. Josef Glatz commented on patch set 1 07/11/18, 09:02

    Hey Benny, basically my patch works. My actual problem is, that the option isn't shown within the scheduler. What do you think: Is it maybe a better idea t hide the progress by default? - If this task is executed via TYPO3 scheduler: nobody cares about the progress - If this task is executed via cron/CLI directly/manually: you are mostly aware of the --help command to find a possible option like "--show-progress"
  3. TYPO3com voted on patch set 1 V +1 07/11/18, 09:04 Completed build in 07m 01s on Wed, 11 Jul, 11:04 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25286

  4. Mathias Brodala commented on patch set 1 CR -1 07/11/18, 09:12

    LanguagePackCommand.php:49

    Please don't add an option for this but use the verbosity levels from Symfony Console instead.
  5. Josef Glatz commented on patch set 1 07/11/18, 09:22

    > (1 comment) @Mathias: so you mean it wil be really a better idea to disable the progress by default? (as stated in my first comment?)
  6. Josef Glatz commented on patch set 1 07/11/18, 09:23

    > (1 comment) And don't forget, this option/setting must also be usable when the command is executed by TYPO3 scheduler (like described in the forge issue)
  7. Mathias Brodala commented on patch set 1 07/11/18, 09:27

    > > (1 comment) > > And don't forget, this option/setting must also be usable when the > command is executed by TYPO3 scheduler (like described in the forge > issue) Why? There is no point at all having CLI progress output shown in the Scheduler module. As with any other TYPO3 command there is no need to set the command verbosity for tasks in the Scheduler module.
  8. Josef Glatz commented on patch set 1 07/11/18, 09:31

    > > > (1 comment) > > > > And don't forget, this option/setting must also be usable when > the > > command is executed by TYPO3 scheduler (like described in the > forge > > issue) > > Why? There is no point at all having CLI progress output shown in > the Scheduler module. As with any other TYPO3 command there is no > need to set the command verbosity for tasks in the Scheduler > module. I try to describe it in other words: I often get mails from the cronjob which executes the TYPO3 scheduler cli command. I only get an email, if some errors occurs except the languagePackCommand: it does always produce the annoying progress which leads into an email.
  9. Mathias Brodala commented on patch set 1 07/11/18, 09:34

    > I try to describe it in other words: I often get mails from the > cronjob which executes the TYPO3 scheduler cli command. I only get > an email, if some errors occurs except the languagePackCommand: it > does always produce the annoying progress which leads into an > email. Yes, and this can be avoided if there is no output by default unless someone passes at least "-v" via CLI which in turn will never happen when a command is executed as Scheduler task.
  10. Josef Glatz voted on patch set 1 V -1 CR -1 07/11/18, 09:45

  11. Josef Glatz uploaded patch set 2 07/11/18, 09:51

  1. Josef Glatz voted on patch set 2 CR -1 07/11/18, 09:53

  2. Josef Glatz uploaded patch set 3 07/11/18, 09:54

  3. TYPO3com voted on patch set 2 V +1 07/11/18, 09:58 Completed build in 06m 45s on Wed, 11 Jul, 11:58 AM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25289

  4. Josef Glatz updated the commit message in patch set 4 07/11/18, 09:59

  5. TYPO3com voted on patch set 3 V +1 07/11/18, 10:02 Completed build in 07m 34s on Wed, 11 Jul, 12:02 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25290

  6. Mathias Brodala commented on patch set 4 CR -1 07/11/18, 10:04

    LanguagePackCommand.php:82

    Please try to inject a NullOutput here instead if not verbose.
  7. TYPO3com voted on patch set 4 V +1 07/11/18, 10:07 Completed build in 07m 59s on Wed, 11 Jul, 12:07 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25291

  8. Josef Glatz uploaded patch set 5 07/11/18, 10:36

  9. Josef Glatz rebased onto patch set 6 07/11/18, 10:37

  10. Josef Glatz uploaded patch set 7 07/11/18, 10:38

  11. TYPO3com voted on patch set 5 V +1 07/11/18, 10:45 Completed build in 08m 40s on Wed, 11 Jul, 12:45 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25292

  12. TYPO3com voted on patch set 6 V +1 07/11/18, 10:47 Completed build in 09m 21s on Wed, 11 Jul, 12:47 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25293

  13. TYPO3com voted on patch set 7 V +1 07/11/18, 10:49 Completed build in 10m 45s on Wed, 11 Jul, 12:49 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25294

  14. Alexander Grein voted on patch set 7 CR +1 07/11/18, 21:26

  15. Josef Glatz updated the commit message in patch set 8 07/12/18, 14:58

  16. Josef Glatz updated the commit message in patch set 9 07/12/18, 14:59

  17. TYPO3com voted on patch set 8 V +1 07/12/18, 15:05 Completed build in 06m 40s on Thu, 12 Jul, 05:05 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25334

  18. TYPO3com voted on patch set 9 V +1 07/12/18, 15:07 Completed build in 08m 13s on Thu, 12 Jul, 05:07 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25335

  19. Benni Mack voted on patch set 9 V +1 CR +1 07/12/18, 17:57

  20. Josef Glatz commented on patch set 9 07/12/18, 18:05

    Thx Benni! Additional side note: Calling the command (based on extbase) within TYPO3 6.2 via cli doesn't output anything per default
  21. Alexander Grein voted on patch set 9 CR +1 07/12/18, 21:51

  22. Mathias Brodala voted on patch set 9 CR +1 07/13/18, 07:44

  23. Mathias Brodala voted on patch set 9 V +1 07/13/18, 07:49

  24. Mathias Brodala voted on patch set 9 V +2 CR +2 07/13/18, 07:49

  25. Mathias Brodala merged patch set 10 07/13/18, 07:49