Review main Merged

57532[BUGFIX] Respect mountpoint variable in cObj menu runtime cache

Sascha Egerer CR +2 V +2 Easy +2 −2 updated 09/30/18, 11:45

Commit message

The mountpoint variable must be respected in the key used for the
menu runtime cache. Without that part in the key all links generated
to a mount-point sub-page will link to the first mount target page
in the menu.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1014

  1. Sascha Egerer uploaded patch set 1 07/11/18, 15:06

  2. Sascha Egerer updated the commit message in patch set 2 07/11/18, 15:11

  3. TYPO3com voted on patch set 1 V +1 07/11/18, 15:13 Completed build in 07m 07s on Wed, 11 Jul, 05:13 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25301

  4. TYPO3com voted on patch set 2 V +1 07/11/18, 15:18 Completed build in 07m 07s on Wed, 11 Jul, 05:18 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25302

  5. Sascha Egerer uploaded patch set 3 09/21/18, 10:25

  6. Sascha Egerer rebased onto patch set 4 09/21/18, 10:27

  7. TYPO3com voted on patch set 3 V +1 09/21/18, 10:47 Completed build in 18m 07s on Fri, 21 Sep, 12:47 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28522

  8. TYPO3com voted on patch set 4 V +1 09/21/18, 11:03 Completed build in 34m 05s on Fri, 21 Sep, 01:03 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28526

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/30/18, 10:08

  10. Wouter Wolters voted on patch set 4 CR +1 09/30/18, 10:31

  11. Christian Kuhn commented on patch set 4 09/30/18, 11:23

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f591118be829f28bb4fb16320ef229b314e4b611
  12. Christian Kuhn commented on patch set 4 CR -1 09/30/18, 11:23

    on it.
  13. Christian Kuhn voted on patch set 4 V +2 CR +2 09/30/18, 11:45

  14. Christian Kuhn merged patch set 5 09/30/18, 11:45