Review main Merged

57558[SECURITY] Introduce PHP stream wrapper for phar:// protocol

Oliver Hader CR +2 V +2 Expert +1013 −0 updated 07/12/18, 09:35

Commit message

This custom stream wrapper for the phar:// protocol overrides
PHP's native handling. In case Phar bundles shall be loaded from
a valid directory, the custom wrapper falls back to the native PHP
wrapper in order to invoke Phar-related actions.

In case the location is not trustworthy, an according exception
is thrown. The custom stream wrapper is registered in the beginning
of TYPO3's bootstrap class.

Truested locations are those in typo3conf/ext/* - anything else is
denied and not considered as trustworthy.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 6

Review log 3

  1. Oliver Hader uploaded patch set 1 07/12/18, 09:35

  2. Oliver Hader commented on patch set 1 V +2 CR +2 07/12/18, 09:35

    Auto-approved
  3. Oliver Hader merged patch set 2 07/12/18, 09:35