Review main Merged

57581[TASK] Move verbosity settings into TemplateService

Benni Mack CR +2 V +2 Easy +20 −16 updated 07/13/18, 15:32

Commit message

The constructor of TemplateService now has
a context, which knows everything to define
public settings to define if tt_track and verbose
should be set.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1417

  1. Benni Mack uploaded patch set 1 07/12/18, 18:16

  2. TYPO3com voted on patch set 1 V +1 07/12/18, 18:24 Completed build in 07m 56s on Thu, 12 Jul, 08:24 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25338

  3. Markus Klein commented on patch set 1 07/12/18, 20:53

    TemplateService.php:401

    not necessary, we are in boolean context
  4. Markus Klein commented on patch set 2 07/12/18, 20:54

    Published edit on patch set 1.
  5. Markus Klein voted on patch set 2 V +1 CR +1 07/12/18, 20:54

  6. Benni Mack commented on patch set 2 CR -1 07/12/18, 20:55

    one sec
  7. Markus Klein voted on patch set 2 V 0 07/12/18, 20:56

  8. Markus Klein commented on patch set 2 CR 0 07/12/18, 20:57

    have to look into the default values again.
  9. Benni Mack uploaded patch set 3 07/12/18, 20:58

  10. Markus Klein commented on patch set 3 07/12/18, 21:00

    TemplateService.php:401

    not sure whether this is correct. verbose is defined to be true if: - in FE a BE_USER is logged-in - in BE when the BE_USER needs information about the template (TypoScript module) BE user alone is not sufficient in BE context
  11. Benni Mack commented on patch set 3 07/12/18, 21:02

    TemplateService.php:401 Reply

    sure... however $templateService->setVerbose() is never turned on in BE context.
  12. TYPO3com voted on patch set 2 V +1 07/12/18, 21:03 Completed build in 08m 19s on Thu, 12 Jul, 11:03 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25347

  13. TYPO3com voted on patch set 3 V +1 07/12/18, 21:05 Completed build in 07m 12s on Thu, 12 Jul, 11:05 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25348

  14. Christian Kuhn voted on patch set 3 V +1 CR +1 07/13/18, 15:28

  15. Anja Leichsenring voted on patch set 3 V +1 CR +1 07/13/18, 15:31

  16. Benni Mack voted on patch set 3 V +2 CR +2 07/13/18, 15:32

  17. Benni Mack merged patch set 4 07/13/18, 15:32