57581[TASK] Move verbosity settings into TemplateService
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php+5 −3
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+12 −7
- typo3/sysext/core/Classes/TypoScript/TemplateService.php3+2 −0
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+0 −2
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/TemplateServiceTest.php+0 −1
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −2
Review log 1417
-
Benni Mack uploaded patch set 1 07/12/18, 18:16
-
TYPO3com voted on patch set 1 V +1 07/12/18, 18:24 Completed build in 07m 56s on Thu, 12 Jul, 08:24 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25338
-
Markus Klein commented on patch set 1 07/12/18, 20:53
-
Markus Klein commented on patch set 2 07/12/18, 20:54
Published edit on patch set 1. -
Markus Klein voted on patch set 2 V +1 CR +1 07/12/18, 20:54
-
Benni Mack commented on patch set 2 CR -1 07/12/18, 20:55
one sec -
Markus Klein voted on patch set 2 V 0 07/12/18, 20:56
-
Markus Klein commented on patch set 2 CR 0 07/12/18, 20:57
have to look into the default values again. -
Benni Mack uploaded patch set 3 07/12/18, 20:58
-
Markus Klein commented on patch set 3 07/12/18, 21:00
TemplateService.php:401not sure whether this is correct. verbose is defined to be true if: - in FE a BE_USER is logged-in - in BE when the BE_USER needs information about the template (TypoScript module) BE user alone is not sufficient in BE context -
Benni Mack commented on patch set 3 07/12/18, 21:02
TemplateService.php:401Replysure... however $templateService->setVerbose() is never turned on in BE context. -
TYPO3com voted on patch set 2 V +1 07/12/18, 21:03 Completed build in 08m 19s on Thu, 12 Jul, 11:03 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25347
-
TYPO3com voted on patch set 3 V +1 07/12/18, 21:05 Completed build in 07m 12s on Thu, 12 Jul, 11:05 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25348
-
Christian Kuhn voted on patch set 3 V +1 CR +1 07/13/18, 15:28
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 07/13/18, 15:31
-
Benni Mack voted on patch set 3 V +2 CR +2 07/13/18, 15:32
-
Benni Mack merged patch set 4 07/13/18, 15:32
TemplateService.php:401