Review main Merged

57586[TASK] Add details to message for existing record localization

Mathias Brodala CR +2 V +2 Easy +9 −3 updated 09/03/18, 15:44

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Mathias Brodala uploaded patch set 1 07/13/18, 13:32

  2. TYPO3com voted on patch set 1 V -1 07/13/18, 13:39 Completed build in 07m 13s on Fri, 13 Jul, 03:39 PM Test Summary: 357 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25364

  3. Mathias Brodala commented on patch set 2 07/13/18, 13:45

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 07/13/18, 13:52 Completed build in 06m 30s on Fri, 13 Jul, 03:52 PM Test Summary: 357 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25365

  5. Anja Leichsenring updated the commit message in patch set 3 08/05/18, 13:53

  6. Anja Leichsenring commented on patch set 3 08/05/18, 13:57

    I triggered the test build, Functional tests are failing. Will you look after the issue?
  7. TYPO3com voted on patch set 3 V -1 08/05/18, 14:00 Completed build in 06m 49s on Sun, 5 Aug, 04:00 PM Test Summary: 358 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26203

  8. Mathias Brodala uploaded patch set 4 09/03/18, 14:58

  9. Mathias Brodala commented on patch set 4 09/03/18, 15:02

    Rebased and fixed regression. I missed that BackendUtility::getRecordLocalization() can also return an empty array.
  10. TYPO3com voted on patch set 4 V +1 09/03/18, 15:07 Completed build in 08m 54s on Mon, 3 Sep, 05:07 PM Test Summary: 36010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27651

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/03/18, 15:31

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 09/03/18, 15:44

  13. Christian Kuhn merged patch set 5 09/03/18, 15:44