Review main Merged

57587[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Oliver Hader CR +2 V +2 Easy +1 −1 updated 07/30/18, 14:51

Commit message

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Oliver Hader uploaded patch set 1 07/13/18, 14:49

  2. TYPO3com voted on patch set 1 V +1 07/13/18, 14:57 Completed build in 07m 45s on Fri, 13 Jul, 04:57 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25367

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 07/13/18, 16:39

    fo' real?
  4. Wouter Wolters updated the commit message in patch set 2 07/13/18, 18:22

  5. Wouter Wolters voted on patch set 2 CR +1 07/13/18, 18:22

  6. TYPO3com voted on patch set 2 V +1 07/13/18, 18:30 Completed build in 07m 41s on Fri, 13 Jul, 08:30 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25387

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 07/13/18, 18:40

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 07/13/18, 20:09

  9. Christian Kuhn merged patch set 3 07/13/18, 20:09

  10. Christian Kuhn commented on patch set 3 07/13/18, 20:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 318366dd4d7c3cbb70687cc8f87f03c6277a8720
  11. Oliver Hader commented on patch set 3 07/30/18, 14:51

    Cherry Picked This patchset was cherry picked to branch 9.3 as commit f93e7c1b8af1db0fedbddddcb438071b740b81dc