Review main Merged

57590[TASK] Use RootlineUtility directly

Benni Mack CR +2 V +2 Hard +358 −149 updated 07/24/18, 05:42

Commit message

Instead of calling PageRepository to fetch the rootline, RootlineUtility
can do that now directly.

However, all exceptions are more specific and caught specifically, for
each use-case.

Additionally, PageRepository->getRootline() is deprecated now. For this
reason, the deprecation for the argument $ignoreMPerrors is removed
again, as it does not make sense anymore.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1320

  1. Benni Mack uploaded patch set 1 07/13/18, 18:54

  2. TYPO3com voted on patch set 1 V -1 07/13/18, 19:01 Completed build in 06m 51s on Fri, 13 Jul, 09:01 PM Test Summary: 54 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25391

  3. Benni Mack uploaded patch set 2 07/13/18, 19:23

  4. TYPO3com voted on patch set 2 V -1 07/13/18, 19:30 Completed build in 07m 08s on Fri, 13 Jul, 09:30 PM Test Summary: 33 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25395

  5. Benni Mack uploaded patch set 3 07/13/18, 20:35

  6. TYPO3com voted on patch set 3 V -1 07/13/18, 20:42 Completed build in 07m 16s on Fri, 13 Jul, 10:42 PM Test Summary: 33 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25404

  7. Benni Mack uploaded patch set 4 07/13/18, 20:55

  8. TYPO3com voted on patch set 4 V -1 07/13/18, 21:02 Completed build in 06m 48s on Fri, 13 Jul, 11:02 PM Test Summary: 12 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25405

  9. Andreas Kienast rebased onto patch set 5 07/23/18, 18:11

  10. Andreas Kienast commented on patch set 5 CR -1 07/23/18, 18:12

    PageRepository.php:1121 Unresolved

    Since the whole method is deprecated now, do we want to drop the marked deprecation again?
  11. TYPO3com voted on patch set 5 V -1 07/23/18, 18:19 Completed build in 07m 32s on Mon, 23 Jul, 08:19 PM Test Summary: 12 of 33658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25680

  12. Andreas Kienast uploaded patch set 6 07/23/18, 18:38

  13. TYPO3com voted on patch set 6 V +1 07/23/18, 18:47 Completed build in 08m 40s on Mon, 23 Jul, 08:47 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25682

  14. Andreas Kienast uploaded patch set 7 07/23/18, 18:54

  15. TYPO3com voted on patch set 7 V +1 07/23/18, 19:02 Completed build in 07m 44s on Mon, 23 Jul, 09:02 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25684

  16. Andreas Kienast voted on patch set 7 V +1 CR +1 07/23/18, 19:10

  17. Anja Leichsenring commented on patch set 7 07/23/18, 19:30

    SearchController.php:1400

    sure it is safe to remove the is_array check? RootlineUtility->get() does not ensure to return an array.
  18. Anja Leichsenring commented on patch set 7 V +1 CR +1 07/23/18, 19:33

    > Patch Set 7: > > (1 comment)

    SearchController.php:1400 Reply

    forget it, it will always be an array. generateRootlineCache will always write an array into the runtime cache. So it would only fail if the cache is corrupted, and when this happens you have other problems.
  19. Benni Mack voted on patch set 7 V +2 CR +2 07/24/18, 05:42

  20. Benni Mack merged patch set 8 07/24/18, 05:42