Review main Merged

57593[TASK] Deprecate PageRepository->checkWorkspaceAccess

Benni Mack CR +2 V +2 Easy +45 −2 updated 07/21/18, 16:36

Commit message

An unused if() statement removes the last occurrence
of this method, so it can be deprecated.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Andreas Kienast +1
  • Verified V +2
    • Jigal van Hemert +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1319

  1. Benni Mack uploaded patch set 1 07/13/18, 20:00

  2. TYPO3com voted on patch set 1 V +1 07/13/18, 20:07 Completed build in 06m 32s on Fri, 13 Jul, 10:07 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25396

  3. Benni Mack uploaded patch set 2 07/13/18, 20:20

  4. Andreas Kienast voted on patch set 2 CR +1 07/13/18, 20:28

  5. TYPO3com voted on patch set 2 V +1 07/13/18, 20:28 Completed build in 08m 06s on Fri, 13 Jul, 10:28 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25401

  6. Benni Mack uploaded patch set 3 07/19/18, 06:04

  7. TYPO3com voted on patch set 3 V +1 07/19/18, 06:12 Completed build in 08m 20s on Thu, 19 Jul, 08:12 AM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25539

  8. Tobias Wollender commented on patch set 3 07/19/18, 08:06

    PageRepository.php:1966 Unresolved

    Shouldn't this be TYPO3 v9.x?
  9. Benni Mack commented on patch set 4 07/19/18, 09:29

    Published edit on patch set 3.
  10. Benni Mack commented on patch set 4 07/19/18, 09:29

    Thanks, Tobias. Fixed.
  11. TYPO3com voted on patch set 4 V +1 07/19/18, 09:38 Completed build in 08m 50s on Thu, 19 Jul, 11:38 AM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25545

  12. Benni Mack uploaded patch set 5 07/20/18, 08:29

  13. Andreas Kienast voted on patch set 5 CR +1 07/20/18, 08:33

  14. TYPO3com voted on patch set 5 V +1 07/20/18, 08:36 Completed build in 06m 58s on Fri, 20 Jul, 10:36 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25597

  15. Benni Mack uploaded patch set 6 07/20/18, 08:44

  16. TYPO3com voted on patch set 6 V +1 07/20/18, 08:53 Completed build in 08m 38s on Fri, 20 Jul, 10:53 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25600

  17. Andreas Kienast voted on patch set 6 V +1 CR +1 07/20/18, 13:16

  18. Jigal van Hemert voted on patch set 6 V +2 CR +2 07/21/18, 16:36

  19. Jigal van Hemert merged patch set 7 07/21/18, 16:36