Review TYPO3_8-7 Merged

57595[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/24/18, 19:29

Commit message

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn commented on patch set 1 07/13/18, 20:09

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 07/13/18, 20:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0ee3052b3699bb005ab4189abf48b0e2b2115bfa
  3. TYPO3com voted on patch set 1 V +1 07/13/18, 20:19 Completed build in 09m 58s on Fri, 13 Jul, 10:19 PM Test Summary: 59222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2717

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/13/18, 20:20

  5. Christian Kuhn merged patch set 2 07/13/18, 20:20

  6. Jigal van Hemert commented on patch set 2 V +1 CR +1 07/24/18, 19:29

    Works, but on windows (XAMPP for Windows, PHP 7.2.0) open_basedir is hell. Even setting it to the root of both drives produces exceptions about open_basedir restrictions.