57597[TASK] Deprecate TypoScriptFrontendController->getUniqueId
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Josef Glatz +1
- Jörg Bösche +1
-
Verified V +2
- Frank Nägler +2
- Josef Glatz +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1215
-
Benni Mack uploaded patch set 1 07/13/18, 20:26
-
Andreas Kienast voted on patch set 1 CR +1 07/13/18, 20:30
-
TYPO3com voted on patch set 1 V +1 07/13/18, 20:34 Completed build in 07m 33s on Fri, 13 Jul, 10:34 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25402
-
Josef Glatz commented on patch set 1 07/14/18, 05:20
-
Benni Mack commented on patch set 2 07/16/18, 14:04
Published edit on patch set 1. -
Benni Mack commented on patch set 2 07/16/18, 14:04
fixed. thanks -
TYPO3com voted on patch set 2 V +1 07/16/18, 14:12 Completed build in 07m 51s on Mon, 16 Jul, 04:12 PM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25469
-
Georg Ringer voted on patch set 2 V +1 CR +1 07/17/18, 01:54
-
Josef Glatz updated the commit message in patch set 3 07/17/18, 04:19
-
Josef Glatz commented on patch set 3 V +1 CR +1 07/17/18, 04:20
> adopted commit message due commit message guidelines -
TYPO3com voted on patch set 3 V +1 07/17/18, 04:27 Completed build in 08m 05s on Tue, 17 Jul, 06:27 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25483
-
Jörg Bösche voted on patch set 3 V +1 CR +1 07/18/18, 05:49
-
Stefan Neufeind commented on patch set 3 07/18/18, 08:56
The getUniqueId() in StringUtility then also feels wrong, but is used in a number of places throughout the core. Should we maybe provide a function in a Singleton to take care of both cases, provided by the core? -
Frank Nägler voted on patch set 3 V +2 CR +2 07/18/18, 16:59
-
Frank Nägler merged patch set 4 07/18/18, 16:59
TypoScriptFrontendController.php:691