Review main Merged

57607[TASK] Turn redis cache backend unit into functional tests

Christian Kuhn CR +2 V +2 Expert +949 −1016 updated 07/16/18, 00:45

Commit message

Our unit tests should not rely on running daemons, there is
a functional test environment to take care of this. The patch
turns redis cache backend unit tests into funcitional tests
and adapts the unit test setup to no longer start dependencies.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 58

  1. Christian Kuhn uploaded patch set 1 07/16/18, 00:12

  2. TYPO3com voted on patch set 1 V -1 07/16/18, 00:20 Completed build in 07m 57s on Mon, 16 Jul, 02:20 AM Test Summary: 9 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25448

  3. Christian Kuhn uploaded patch set 2 07/16/18, 00:22

  4. TYPO3com voted on patch set 2 V -1 07/16/18, 00:30 Completed build in 08m 20s on Mon, 16 Jul, 02:30 AM Test Summary: 6 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25449

  5. Christian Kuhn uploaded patch set 3 07/16/18, 00:37

  6. TYPO3com voted on patch set 3 V +1 07/16/18, 00:45 Completed build in 07m 43s on Mon, 16 Jul, 02:45 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25450

  7. Christian Kuhn voted on patch set 3 V +2 CR +2 07/16/18, 00:45

  8. Christian Kuhn merged patch set 4 07/16/18, 00:45