57609[FEATURE] Add scheduler information to system information toolbar
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stefanos Karasavvidis +1
- Jan Helke +1
-
Verified V +2
- Georg Ringer +2
- Stefanos Karasavvidis +1
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-85569-ShowSchedulerInformationsInTheSystemInformationToolbar.rstnew+29 −0
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.phpnew+164 −0
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/scheduler/ext_localconf.php+9 −0
Review log 5169
Show 3344 earlier messages
-
Josef Glatz uploaded patch set 1 07/16/18, 09:23
-
Josef Glatz updated the commit message in patch set 2 07/16/18, 09:29
-
Mathias Brodala commented on patch set 2 CR -1 07/16/18, 09:30
This is a feature, also please add a RST for this.... now ... ;-) -
TYPO3com voted on patch set 1 V +1 07/16/18, 09:31 Completed build in 08m 08s on Mon, 16 Jul, 11:31 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25457
-
TYPO3com voted on patch set 2 V +1 07/16/18, 09:37 Completed build in 08m 12s on Mon, 16 Jul, 11:37 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25458
-
Josef Glatz uploaded patch set 3 07/16/18, 10:03
-
TYPO3com voted on patch set 3 V +1 07/16/18, 10:11 Completed build in 07m 59s on Mon, 16 Jul, 12:11 PM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25459
-
Georg Ringer commented on patch set 3 07/16/18, 11:04
see duplicate https://review.typo3.org/#/c/57602/ -
Georg Ringer commented on patch set 3 07/16/18, 11:15
IconRegistry.php:296use extensions-scheduler-run-taskScheduler.php:28more speaking name -
Josef Glatz uploaded patch set 4 07/16/18, 18:22
-
TYPO3com voted on patch set 4 V +1 07/16/18, 18:30 Completed build in 07m 35s on Mon, 16 Jul, 08:30 PM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25480
-
Jörg Bösche commented on patch set 4 CR -1 07/18/18, 06:16
Toolbar.php:36strict return type missing? (:void)Toolbar.php:69what do you think of it when the 2 cases are extracted to methods? For example, "checkState(), getLastRunInfo()"Toolbar.php:75Can we use the /typo3/cms/typo3/sysext/backend/Classes/Utility/BackendUtility.php:1544 class with the method calcAge() here? -
Josef Glatz uploaded patch set 5 07/27/18, 20:49
-
TYPO3com voted on patch set 5 V -1 07/27/18, 20:49 Completed build in 09s on Fri, 27 Jul, 10:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25851
-
Josef Glatz commented on patch set 4 07/27/18, 20:53
Love to see some feedbackToolbar.php:36ReplyDoneToolbar.php:69ReplyCan you better explain it please? Why 2 methods? - checkState() for check if last run is imcomplete? - getLastRunInfo() makes only sense for me if a constructor is added to the class where the property $this->lastRunInfo can be saved. Would be also ok if you can write mit in Slack directly :-]Toolbar.php:75ReplyDone -
Josef Glatz rebased onto patch set 6 07/28/18, 03:18
-
TYPO3com commented on patch set 6 07/28/18, 03:19 Completed build in 10s on Sat, 28 Jul, 05:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25854
-
Josef Glatz uploaded patch set 7 07/28/18, 03:19
-
Josef Glatz rebased onto patch set 8 07/28/18, 03:25
-
TYPO3com voted on patch set 7 V +1 07/28/18, 03:26 Completed build in 06m 52s on Sat, 28 Jul, 05:26 AM Test Summary: 33497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25855
-
TYPO3com voted on patch set 8 V +1 07/28/18, 03:31 Completed build in 06m 37s on Sat, 28 Jul, 05:31 AM Test Summary: 33497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25856
-
Jörg Bösche commented on patch set 8 V +1 CR +1 07/28/18, 10:02
As I wrote you in Slack, it's just a nice 2 have for readability and understanding of the source code. (Buzzword: clean code) But it is not a show stopper. ;-) -
Josef Glatz voted on patch set 8 CR -1 07/31/18, 13:26
-
Guido Schmechel commented on patch set 8 08/11/18, 19:53
Basically, it runs and therefore first thanks for the feature! My optional wishes: - Show the title of the latest job - Link "Latest run" to the scheduler module - Configure the possible view in the SysToolba (extConf in Scheduler?) -
Tymoteusz Motylewski commented on patch set 8 08/26/18, 09:31
Is it a duplicate of https://review.typo3.org/#/c/57602/ ? -
Tobi Kretschmann voted on patch set 8 CR +1 09/19/18, 13:14
-
Josef Glatz uploaded patch set 9 09/23/18, 18:26
-
Josef Glatz commented on patch set 9 09/23/18, 18:28
> Is it a duplicate of https://review.typo3.org/#/c/57602/ ? It's more vice versa due the fact, that Georg's patch was uploaded as a private draft on Gerrit before he made him public. But it's ok for me if George's patch is preferred instead of mine -
Josef Glatz commented on patch set 9 09/23/18, 18:33
> Basically, it runs and therefore first thanks for the feature! > > My optional wishes: > - Show the title of the latest job This is something out of scope for this patch. This must be implemented within scheduler. Actually this info isn't present in the lastRunInfo array. > - Link "Latest run" to the scheduler module If you know a possibility to add a link within the $value argument handed over to the addSystemInformation() method please let me know or update the patch. But anyway, a link is added through the addSystemMessage() method, if there's no lastRunInfo in sysRegistry. > - Configure the possible view in the SysToolba (extConf in > Scheduler?) Done, thanks for this nice idea! -
Josef Glatz commented on patch set 9 09/23/18, 18:34
> As I wrote you in Slack, it's just a nice 2 have for readability > and understanding of the source code. (Buzzword: clean code) > But it is not a show stopper. ;-) Cleaned up the code! thanks for your input! -
TYPO3com voted on patch set 9 V +1 09/23/18, 18:34 Completed build in 08m 13s on Sun, 23 Sep, 08:34 PM Test Summary: 36099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28562
-
Jan Helke voted on patch set 9 V +1 CR +1 09/28/18, 07:52
-
Jan Helke commented on patch set 9 09/28/18, 07:59
As we have a feature freeze for 9 LTS in place, we will merge this one early in 10.0. -
Frank Nägler commented on patch set 9 V +1 CR -2 09/28/18, 11:39
Very nice feature, but not for v9 anymore. I will block it until v9 is released and the branching has been done. -
Josef Glatz rebased onto patch set 10 12/14/18, 11:32
-
TYPO3com voted on patch set 10 V +1 12/14/18, 12:01 Completed build in 12m 38s on Fri, 14 Dec, 01:01 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30709
-
Joerg Kummer commented on patch set 10 V -1 12/14/18, 16:06
I like this feature. But I could not reproduce the warning, if execution seems not to be configured correctly. How to do so? Should this feature implement, that a failed execution is highlighted too like (manual execution)? -
Josef Glatz commented on patch set 10 12/14/18, 17:46
> I like this feature. But I could not reproduce the warning, if > execution seems not to be configured correctly. How to do so? > Should this feature implement, that a failed execution is > highlighted too like (manual execution)? This patch uses the existing information from sys_registry only. The warning is only shown, if there is no lastRunInformation available within the sys_registry. The test this: just remove the entry from the sys_registry. What do you mean with failed execution? Basically every other part of the shown information is gathered from - end - start - type of the registry entry. -
Frank Nägler voted on patch set 10 CR 0 12/14/18, 20:39
-
Joerg Kummer wrote 12/15/18, 06:18
Removed Verified-1 by Joerg Kummer <typo3@enobe.de> -
Joerg Kummer commented on patch set 10 V +1 12/15/18, 06:28
@Josef Glatz: Got it. Thanks for your hint. What I mean with failed execution would require to read further information from tx_scheduler_task.lastexecution_failure which would be more komplex to eval. Drop my thought within this patch. -
Andreas Kienast uploaded patch set 11 12/16/18, 16:58
-
TYPO3com voted on patch set 11 V +1 12/16/18, 17:09 Completed build in 10m 26s on Sun, 16 Dec, 06:09 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30744
-
Josef Glatz rebased onto patch set 12 12/22/18, 14:42
-
TYPO3com voted on patch set 12 V +1 12/22/18, 15:04 Completed build in 16m 20s on Sat, 22 Dec, 04:04 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31084
-
Josef Glatz rebased onto patch set 13 12/28/18, 10:51
-
TYPO3com voted on patch set 13 V +1 12/28/18, 11:02 Completed build in 11m 04s on Fri, 28 Dec, 12:02 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31152
-
Jan Helke voted on patch set 13 V +1 CR +1 12/28/18, 11:14
-
Georg Ringer voted on patch set 13 V +1 CR +1 01/01/19, 19:31
-
Jörg Bösche voted on patch set 13 CR +1 01/04/19, 12:16
-
Andreas Kienast voted on patch set 13 V +1 CR +1 01/04/19, 12:34
-
Benni Mack commented on patch set 13 01/04/19, 13:17
Toolbar.php:91we already have this in "LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.minutesHoursDaysYears". Also, usually we use "GLOBALS['LANG'] instead of Extbase's Utility class in non-extbase-environments -
Mathias Brodala commented on patch set 13 01/04/19, 13:31
Toolbar.php:29Can we name this ToolbarItemProvider or similar instead? -
Andreas Kienast uploaded patch set 14 01/06/19, 15:04
-
Andreas Kienast voted on patch set 14 V +1 CR +1 01/06/19, 15:06
-
Jan Helke voted on patch set 14 V +1 CR +1 01/06/19, 15:07
-
TYPO3com voted on patch set 14 V +1 01/06/19, 15:15 Completed build in 10m 22s on Sun, 6 Jan, 04:15 PM Test Summary: 47689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31251
-
Benni Mack uploaded patch set 15 01/07/19, 05:39
-
Benni Mack uploaded patch set 16 01/07/19, 05:44
-
TYPO3com voted on patch set 15 V +1 01/07/19, 05:52 Completed build in 12m 36s on Mon, 7 Jan, 06:52 AM Test Summary: 47687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31263
-
TYPO3com voted on patch set 16 V +1 01/07/19, 05:55 Completed build in 10m 32s on Mon, 7 Jan, 06:55 AM Test Summary: 47687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31264
-
Josef Glatz commented on patch set 17 01/07/19, 05:57
Published edit on patch set 16. -
Josef Glatz commented on patch set 18 01/07/19, 06:00
Published edit on patch set 17. -
TYPO3com voted on patch set 17 V +1 01/07/19, 06:10 Completed build in 12m 02s on Mon, 7 Jan, 07:10 AM Test Summary: 47687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31265
-
TYPO3com voted on patch set 18 V +1 01/07/19, 06:11 Completed build in 11m 38s on Mon, 7 Jan, 07:11 AM Test Summary: 47687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31266
-
Jan Helke voted on patch set 18 V +1 CR +1 01/07/19, 08:55
-
Stefanos Karasavvidis voted on patch set 18 V +1 CR +1 01/07/19, 10:40
-
Georg Ringer voted on patch set 18 V +2 CR +2 01/07/19, 13:56
-
Georg Ringer merged patch set 19 01/07/19, 13:56