Review main Merged

57614[TASK] Render wizards of FormEngine elements only if needed

Georg Ringer CR +2 V +2 Normal +140 −97 updated 08/11/18, 20:08

Commit message

Reduce the HTML of a record form by rendering divs of wizards only
if those are required.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 79

  1. Georg Ringer uploaded patch set 1 07/17/18, 02:27

  2. TYPO3com voted on patch set 1 V +1 07/17/18, 02:36 Completed build in 08m 16s on Tue, 17 Jul, 04:36 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25482

  3. Josef Glatz commented on patch set 1 07/17/18, 04:29

    Is it enough to check before/after the patch or does it makes sense to review that patch also with ext:styleguide (to find some side effects)?
  4. Anja Leichsenring uploaded patch set 2 08/10/18, 17:03

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/10/18, 17:03

  6. TYPO3com voted on patch set 2 V +1 08/10/18, 17:11 Completed build in 07m 45s on Fri, 10 Aug, 07:11 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26372

  7. Mona Muzaffar voted on patch set 2 V +1 CR +1 08/10/18, 17:12

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 08/11/18, 20:08

  9. Christian Kuhn merged patch set 3 08/11/18, 20:08