57614[TASK] Render wizards of FormEngine elements only if needed
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Mona Muzaffar +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxLabeledToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+5 −3
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+5 −3
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+12 −8
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+8 −6
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+14 −10
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+12 −8
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+11 −8
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+13 −9
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+12 −8
- typo3/sysext/backend/Classes/View/Wizard/Element/BackendLayoutWizardElement.php+5 −3
- typo3/sysext/rsaauth/Classes/Form/Element/RsaInputElement.php+12 −8
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+12 −8
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+12 −8
Review log 79
-
Georg Ringer uploaded patch set 1 07/17/18, 02:27
-
TYPO3com voted on patch set 1 V +1 07/17/18, 02:36 Completed build in 08m 16s on Tue, 17 Jul, 04:36 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25482
-
Josef Glatz commented on patch set 1 07/17/18, 04:29
Is it enough to check before/after the patch or does it makes sense to review that patch also with ext:styleguide (to find some side effects)? -
Anja Leichsenring uploaded patch set 2 08/10/18, 17:03
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 08/10/18, 17:03
-
TYPO3com voted on patch set 2 V +1 08/10/18, 17:11 Completed build in 07m 45s on Fri, 10 Aug, 07:11 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26372
-
Mona Muzaffar voted on patch set 2 V +1 CR +1 08/10/18, 17:12
-
Christian Kuhn voted on patch set 2 V +2 CR +2 08/11/18, 20:08
-
Christian Kuhn merged patch set 3 08/11/18, 20:08