Review main Merged

57629[TASK] Deprecate enableConcatenateFiles

Benni Mack CR +2 V +2 Normal +74 −3 updated 07/20/18, 08:40

Commit message

Also config.concatenateJsAndCss TypoScript is replaced
with concatenateCss and concatenateJs since TYPO3 v6.0,
and can now be deprecated.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1013

  1. Benni Mack uploaded patch set 1 07/19/18, 10:03

  2. TYPO3com voted on patch set 1 V +1 07/19/18, 10:11 Completed build in 08m 37s on Thu, 19 Jul, 12:11 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25546

  3. Benni Mack uploaded patch set 2 07/19/18, 15:48

  4. TYPO3com voted on patch set 2 V +1 07/19/18, 15:56 Completed build in 07m 54s on Thu, 19 Jul, 05:56 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25562

  5. Wouter Wolters voted on patch set 2 CR +1 07/19/18, 16:05

  6. Daniel Goerz commented on patch set 2 V -1 07/19/18, 17:24

    Getting JS Errors "ReferenceError: TBE_EDITOR is not defined" with every RTE and T3Editor (e.g. tTS Template) with this patch applied.
  7. Daniel Goerz uploaded patch set 3 07/19/18, 17:51

  8. Daniel Goerz commented on patch set 3 07/19/18, 17:52

    > Getting JS Errors "ReferenceError: TBE_EDITOR is not defined" with > every RTE and T3Editor (e.g. tTS Template) with this patch applied. (Only in BE Debug mode)
  9. TYPO3com voted on patch set 3 V +1 07/19/18, 17:57 Completed build in 06m 42s on Thu, 19 Jul, 07:57 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25564

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 07/19/18, 17:59

  11. Daniel Goerz commented on patch set 3 07/19/18, 17:59

    Good thing we merged the dedicated log file for deprecations 10 minutes ago :)
  12. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/20/18, 08:40

  13. Anja Leichsenring merged patch set 4 07/20/18, 08:40