Review main Abandoned

57630[BUGFIX] TMENU: wrap should allow stdWrap-functionality

Stefan Neufeind CR 0 V 0 Easy +2 −1 updated 10/01/18, 18:07

Commit message

wrap usually allows using stdWrap-functionality like
insertData. For TMENU that support should be added
as well.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Stefan Neufeind uploaded patch set 1 07/19/18, 12:08

  2. Stefan Neufeind commented on patch set 1 07/19/18, 12:10

    For democode see forge-issue. Of course this also affects 8.7, but I'm not sure we should backport the fix for that. Imho it's only a fix and not a "feature" since it can well be assumed that "wrap" in a TMENU behaves like other wrap-properties. Without this patch additional settings ("wrap.") are simply ignored.
  3. TYPO3com voted on patch set 1 V +1 07/19/18, 12:16 Completed build in 07m 37s on Thu, 19 Jul, 02:16 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25552

  4. Benni Mack commented on patch set 1 07/19/18, 12:31

    I'd recommend deprecating .wrap in favor of using stdWrap (.wrap etc. ... everything)
  5. Stefan Neufeind commented on patch set 1 07/19/18, 13:16

    I can confirm that (without the patch) the democode also works fine with: stdWrap.wrap = A{page:uid}|B stdWrap.wrap.insertData = 1 (as expected) So yes, we can deprecate a whole lot of separate properties that come from the stdWrap-universe.
  6. Stefan Neufeind commented on patch set 1 CR -1 08/16/18, 07:58

    As discussed let's not add wrap-support for tmenu here but instead deprecate the separate wrap-functionality elsewhere - and recommend using stdWrap-functionality in all places.
  7. Benni Mack abandoned the change 10/01/18, 18:07

    abandoned for now, please come up with a new patch set then.