57630[BUGFIX] TMENU: wrap should allow stdWrap-functionality
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 67
-
Stefan Neufeind uploaded patch set 1 07/19/18, 12:08
-
Stefan Neufeind commented on patch set 1 07/19/18, 12:10
For democode see forge-issue. Of course this also affects 8.7, but I'm not sure we should backport the fix for that. Imho it's only a fix and not a "feature" since it can well be assumed that "wrap" in a TMENU behaves like other wrap-properties. Without this patch additional settings ("wrap.") are simply ignored. -
TYPO3com voted on patch set 1 V +1 07/19/18, 12:16 Completed build in 07m 37s on Thu, 19 Jul, 02:16 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25552
-
Benni Mack commented on patch set 1 07/19/18, 12:31
I'd recommend deprecating .wrap in favor of using stdWrap (.wrap etc. ... everything) -
Stefan Neufeind commented on patch set 1 07/19/18, 13:16
I can confirm that (without the patch) the democode also works fine with: stdWrap.wrap = A{page:uid}|B stdWrap.wrap.insertData = 1 (as expected) So yes, we can deprecate a whole lot of separate properties that come from the stdWrap-universe. -
Stefan Neufeind commented on patch set 1 CR -1 08/16/18, 07:58
As discussed let's not add wrap-support for tmenu here but instead deprecate the separate wrap-functionality elsewhere - and recommend using stdWrap-functionality in all places. -
Benni Mack abandoned the change 10/01/18, 18:07
abandoned for now, please come up with a new patch set then.