Review main Merged

57632[TASK] Deprecate TYPO3_OS constant

Benni Mack CR +2 V +2 Easy +12 −3 updated 07/19/18, 15:45

Commit message

The TYPO3_OS constant is deprecated with
the introduction of Environment API.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Daniel Goerz +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Benni Mack uploaded patch set 1 07/19/18, 15:25

  2. TYPO3com voted on patch set 1 V +1 07/19/18, 15:33 Completed build in 07m 31s on Thu, 19 Jul, 05:33 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25557

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 07/19/18, 15:33

  4. Daniel Goerz voted on patch set 1 V +1 CR +1 07/19/18, 15:39

  5. Markus Klein voted on patch set 1 V +2 CR +2 07/19/18, 15:45

  6. Markus Klein merged patch set 2 07/19/18, 15:45