Review main Merged

57636[TASK] Refer to SimpleDataHandlerController instead of tce_db.php

Tymoteusz Motylewski CR +2 V +2 Easy +11 −15 updated 07/22/18, 13:27

Commit message

Update comments in the code not to mention tce_db.php.

The tce_db.php entry point is gone since v8.
The SimpleDataHandlerController is responsible for pushing data
from request to DataHandler.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1014

  1. Tymoteusz Motylewski uploaded patch set 1 07/19/18, 21:07

  2. Tymoteusz Motylewski updated the commit message in patch set 2 07/19/18, 21:08

  3. Wouter Wolters voted on patch set 2 CR +1 07/19/18, 21:10

  4. Wouter Wolters voted on patch set 2 V +1 07/19/18, 21:10

  5. TYPO3com voted on patch set 1 V -1 07/19/18, 21:15 Completed build in 08m 23s on Thu, 19 Jul, 11:15 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25583

  6. TYPO3com voted on patch set 2 V -1 07/19/18, 21:18 Completed build in 09m 09s on Thu, 19 Jul, 11:18 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25584

  7. Christian Kuhn rebased onto patch set 3 07/19/18, 21:21

  8. Christian Kuhn rebased onto patch set 4 07/19/18, 21:25

  9. TYPO3com voted on patch set 3 V -1 07/19/18, 21:29 Completed build in 07m 40s on Thu, 19 Jul, 11:29 PM Test Summary: 33375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25585

  10. TYPO3com voted on patch set 4 V +1 07/19/18, 21:38 Completed build in 13m 03s on Thu, 19 Jul, 11:38 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25587

  11. Jörg Bösche voted on patch set 4 CR +1 07/20/18, 06:27

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 07/22/18, 11:20

  13. Jigal van Hemert voted on patch set 4 V +2 CR +2 07/22/18, 13:27

  14. Jigal van Hemert merged patch set 5 07/22/18, 13:27