Review main Merged

57640[BUGFIX] Read page ID correctly when drag-dropping content

Claus Due CR +2 V +2 Easy +3 −3 updated 08/03/18, 15:15

Commit message

Fixes an issue where drag and dropping a content element
would send the page title, not the page ID, as part of the
command map DataHandler receives.

The reason was an indiscriminate lookup in DOM for any
element which had any `data-page` attribute and assuming
that the first found object contained the integer value.

Using the drop target’s parent element instead will resolve
the value from the nearest relative place it can be found.

Effect is that DataHandler command hooks can once again
safely assume that the value of the “move” command is the
target page ID, not an arbitrary title on v9 and ID on v8.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Łukasz Uznański +1
    • Paweł Rogowicz +1
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Claus Due uploaded patch set 1 07/20/18, 12:05

  2. Mathias Brodala commented on patch set 1 CR -1 07/20/18, 12:15

    This needs a JS update too.
  3. TYPO3com voted on patch set 1 V -1 07/20/18, 12:18 Completed build in 13m 00s on Fri, 20 Jul, 02:18 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25608

  4. Claus Due commented on patch set 1 07/20/18, 12:45

    > This needs a JS update too. And how do we do that?
  5. Mathias Brodala commented on patch set 1 07/20/18, 12:48

    > Patch Set 1: > > > This needs a JS update too. > > And how do we do that? Via "yarn build-js" from within the "Build" directory, see: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/SetupTypo3.html#yarn-tasks
  6. Andreas Kienast uploaded patch set 2 07/20/18, 13:20

  7. TYPO3com voted on patch set 2 V +1 07/20/18, 15:23 Completed build in 4h 01m 40s on Fri, 20 Jul, 05:23 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25611

  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 07/26/18, 14:05

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/02/18, 15:04

  10. Andreas Kienast uploaded patch set 3 08/03/18, 07:49

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/03/18, 07:55

  12. TYPO3com voted on patch set 3 V +1 08/03/18, 07:55 Completed build in 06m 34s on Fri, 3 Aug, 09:55 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26059

  13. Paweł Rogowicz voted on patch set 3 CR -1 08/03/18, 08:47

  14. Paweł Rogowicz voted on patch set 3 CR +1 08/03/18, 10:44

  15. Łukasz Uznański voted on patch set 3 CR +1 08/03/18, 14:00

  16. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/03/18, 15:15

  17. Anja Leichsenring merged patch set 4 08/03/18, 15:15