Review main Merged

57647[BUGFIX] Allow "defaultValue" for select form elements

Ralf Zimmermann CR +2 V +2 Normal +65 −20 updated 07/30/18, 14:52

Commit message

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 3037

Show 812 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 07/20/18, 20:54

  2. TYPO3com voted on patch set 1 V -1 07/20/18, 21:12 Completed build in 15m 52s on Fri, 20 Jul, 11:12 PM Test Summary: 6 of 33664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25626

  3. Ralf Zimmermann uploaded patch set 2 07/20/18, 23:06

  4. TYPO3com voted on patch set 2 V +1 07/20/18, 23:17 Completed build in 11m 29s on Sat, 21 Jul, 01:17 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25628

  5. Oliver Hader commented on patch set 2 V -1 07/23/18, 15:06

    Missing changes * No hmac found for property "defaultValue.0" (form element "multicheckbox-1") #1528588037 * No hmac found for property "defaultValue.0" (form element "multiselect-1") #1528588037 * No hmac found for property "properties.validationErrorMessages.0.code" (form element "fileupload-1") #1528588037 * No hmac found for property "properties.validationErrorMessages.0.code" (form element "imageupload-1") #1528588037
  6. Ralf Zimmermann commented on patch set 2 CR -1 07/23/18, 15:24

    on it
  7. Ralf Zimmermann uploaded patch set 3 07/23/18, 19:01

  8. TYPO3com voted on patch set 3 V +1 07/23/18, 19:10 Completed build in 08m 19s on Mon, 23 Jul, 09:10 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25685

  9. Markus Klein updated the commit message in patch set 4 07/24/18, 12:33

  10. TYPO3com voted on patch set 4 V +1 07/24/18, 12:40 Completed build in 06m 40s on Tue, 24 Jul, 02:40 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25722

  11. Andreas Kienast commented on patch set 4 07/26/18, 08:22

    MultiValuePropertiesExtractor.php:82

    Can we add the `ArrayUtility::isValidPath()` call here as well? If yes, I opt to move the whole `multiValueProperties` logic out of the if/else construct to reduce duplicate code.
  12. Oliver Hader uploaded patch set 5 07/27/18, 09:31

  1. Oliver Hader commented on patch set 4 07/27/18, 09:32

    MultiValuePropertiesExtractor.php:82 Reply Unresolved

    Done
  2. TYPO3com voted on patch set 5 V +1 07/27/18, 09:38 Completed build in 06m 54s on Fri, 27 Jul, 11:38 AM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25828

  3. Andreas Kienast commented on patch set 5 CR +1 07/27/18, 09:42

    Thanks, that's exactly what I meant.
  4. Oliver Hader voted on patch set 5 V +1 CR +1 07/27/18, 09:47

  5. Oliver Hader commented on patch set 5 07/27/18, 09:49

    How to test: * create new elements in using the form editor module in the backend and fill all available settings (default values and error/validation messages) - most interesting are those having multiple items (multi-select or grid-based elements) * if possible: check custom form elements that you defined individually (those that are not shipped in the TYPO3 core of course)
  6. Christian Kuhn commented on patch set 5 07/27/18, 10:15

    works: note a backend reload is needed after patch has been applied, otherwise a hmac() error is throw after default checking a select.
  7. Christian Kuhn voted on patch set 5 V +1 CR +1 07/27/18, 10:16

  8. Oliver Hader commented on patch set 5 CR -1 07/27/18, 13:00

    Seems like the are some flaws (Anja will respond later)
  9. Christian Kuhn commented on patch set 5 07/27/18, 13:26

    olli, please try to reload backend after applied patch. this made the hmac issue go away for me.
  10. Anja Leichsenring commented on patch set 5 07/27/18, 13:40

    > Patch Set 5: Code-Review-1 > > Seems like the are some flaws (Anja will respond later) I put my findings here: https://forge.typo3.org/issues/85670 please note: this is not caused by this patch, but happens on a clean V8 instance as well. BE reload did not solve it.
  11. Ralf Zimmermann commented on patch set 5 07/27/18, 14:04

    on it
  12. Ralf Zimmermann uploaded patch set 6 07/27/18, 16:40

  13. Ralf Zimmermann commented on patch set 6 CR -1 07/27/18, 16:41

    tmp -1 for testing. Feel free to test it too.
  14. TYPO3com voted on patch set 6 V +1 07/27/18, 16:47 Completed build in 06m 50s on Fri, 27 Jul, 06:47 PM Test Summary: 33491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25844

  15. Andreas Kienast voted on patch set 6 V +1 CR +1 07/27/18, 18:24

  16. Ralf Zimmermann voted on patch set 6 CR 0 07/28/18, 08:59

  17. Oliver Hader uploaded patch set 7 07/28/18, 11:18

  18. Oliver Hader commented on patch set 7 V +1 CR +1 07/28/18, 11:19

    Enhanced some JavaScript code between patch-set 6 and 7...

    Core.js:810

    +1 since that previously resulted in having eg "valu" instead of "value"
  19. TYPO3com voted on patch set 7 V +1 07/28/18, 11:25 Completed build in 06m 58s on Sat, 28 Jul, 01:25 PM Test Summary: 33497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25857

  20. Andreas Kienast voted on patch set 7 CR +1 07/28/18, 11:52

  21. Andreas Kienast voted on patch set 7 V +1 07/28/18, 15:20

  22. Christian Kuhn voted on patch set 7 V +2 CR +2 07/29/18, 08:50

  23. Christian Kuhn merged patch set 8 07/29/18, 08:50

  24. Christian Kuhn commented on patch set 8 07/29/18, 08:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d8363eb6cb971fabb64f7c5df63f3472b00b27a6
  25. Oliver Hader commented on patch set 8 07/30/18, 14:52

    Cherry Picked This patchset was cherry picked to branch 9.3 as commit c835869ae5fc35d2099a3b0adf08294e31f465ee