57648[FEATURE] Add hooks for DatabaseRecordList CSV actions
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Anja Leichsenring +1
- Łukasz Uznański +1
- Jörg Bösche +1
-
Verified V +2
- Jigal van Hemert +2
- Anja Leichsenring +1
- Łukasz Uznański +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1113
-
Guido Schmechel uploaded patch set 1 07/21/18, 09:01
-
TYPO3com voted on patch set 1 V +1 07/21/18, 09:09 Completed build in 07m 33s on Sat, 21 Jul, 11:09 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25629
-
Stephan Großberndt voted on patch set 1 CR +1 07/21/18, 09:24
-
Jigal van Hemert commented on patch set 1 07/21/18, 14:17
Thanks for the patch. In one of the hooks I left some comments to streamline the code a bit. The comments are valid for both hooks. Can you push a new patch?Since we have several types of hooks in the core it would be nice to have a code sample for developers who want to use this hook.DatabaseRecordList.php:1511To prevent notices about missing array keys perhaps it's better to use something like $hooks = $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][__CLASS__]['customizeCsvRow'] ?? []; if (!empty($hooks)) { foreach ($hooks as $hookFunction) {DatabaseRecordList.php:1513It's nicer for the hook code to have descriptive strings as array keys. $hookParameters['row'] instead of $hookParameters[0]DatabaseRecordList.php:1514If you pass $row as a reference in the array the hook function can modify the $row directly without this part having to assign it to the variable again. -
Guido Schmechel uploaded patch set 2 07/21/18, 18:14
-
Guido Schmechel commented on patch set 2 07/21/18, 18:16
Reply
Is the call in the RST file sufficient? Or would you expect sample code in the RST? I think the commit message is okay, because there is the rst file.DatabaseRecordList.php:1511ReplyDoneDatabaseRecordList.php:1513ReplyDoneDatabaseRecordList.php:1514ReplyDone -
TYPO3com voted on patch set 2 V +1 07/21/18, 18:22 Completed build in 07m 42s on Sat, 21 Jul, 08:22 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25635
-
Jörg Bösche voted on patch set 2 CR +1 07/23/18, 07:55
-
Jigal van Hemert commented on patch set 2 V +1 CR +1 07/24/18, 19:35
Thanks for the modifications! -
Anja Leichsenring voted on patch set 2 V +1 CR +1 08/05/18, 09:13
-
Łukasz Uznański voted on patch set 2 V +1 CR +1 08/05/18, 09:36
-
Jigal van Hemert voted on patch set 2 V +2 CR +2 08/05/18, 11:47
-
Jigal van Hemert merged patch set 3 08/05/18, 11:47