Review main Merged

57650[BUGFIX] Respect endOfRange in pagination

Guido Schmechel CR +2 V +2 Easy +6 −0 updated 10/29/18, 10:59

Commit message

If prepareObjectsSlice is called in the pagination with a QueryResult,
the endOfRange is calculated and used for each page.

This ensures that the maximum limit is not exceeded.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Guido Schmechel uploaded patch set 1 07/21/18, 12:56

  2. TYPO3com voted on patch set 1 V +1 07/21/18, 13:09 Completed build in 12m 31s on Sat, 21 Jul, 03:09 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25632

  3. Guido Schmechel uploaded patch set 2 07/21/18, 13:25

  4. TYPO3com voted on patch set 2 V +1 07/21/18, 13:33 Completed build in 07m 42s on Sat, 21 Jul, 03:33 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25633

  5. Benni Mack updated the commit message in patch set 3 10/28/18, 12:47

  6. Benni Mack voted on patch set 3 V +1 CR +1 10/28/18, 12:48

  7. TYPO3com voted on patch set 3 V +1 10/28/18, 13:17 Completed build in 27m 55s on Sun, 28 Oct, 02:17 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29755

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 10/28/18, 13:28

  9. Daniel Goerz commented on patch set 3 V 0 10/28/18, 14:18

    I tested the wrong thing
  10. Susi Moog voted on patch set 3 V +1 10/29/18, 10:56

  11. Benni Mack voted on patch set 3 V +2 CR +2 10/29/18, 10:59

  12. Benni Mack merged patch set 4 10/29/18, 10:59