Review main Merged

57653[BUGFIX] Allow form definitions to be moved or put to recycle folder

Ralf Zimmermann CR +2 V +2 Easy +33 −1 updated 07/30/18, 14:53

Commit message

After fixing the issue of TYPO3-CORE-SA-2018-003 file commands for
form definitions (those ending with new ".form.yaml" extension) has
been limited. Since the "move" command theoretically would allow to
move and rename a file, it has been denied as well. However, it is
okay to move those files around in case the file extension has not
been changed or when being moved to a recycle folder.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Ralf Zimmermann +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Ralf Zimmermann +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Ralf Zimmermann uploaded patch set 1 07/22/18, 11:18

  2. TYPO3com voted on patch set 1 V +1 07/22/18, 11:29 Completed build in 11m 16s on Sun, 22 Jul, 01:29 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25645

  3. Oliver Hader commented on patch set 1 CR -1 07/23/18, 13:30

    On it
  4. Oliver Hader uploaded patch set 2 07/23/18, 14:21

  5. TYPO3com voted on patch set 2 V +1 07/23/18, 14:29 Completed build in 07m 54s on Mon, 23 Jul, 04:29 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25671

  6. Ralf Zimmermann voted on patch set 2 V +1 CR +1 07/23/18, 19:28

  7. Markus Klein voted on patch set 2 CR +1 07/24/18, 12:32

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 07/26/18, 08:31

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 07/26/18, 10:06

  10. Christian Kuhn merged patch set 3 07/26/18, 10:06

  11. Oliver Hader commented on patch set 3 07/30/18, 14:53

    Cherry Picked This patchset was cherry picked to branch 9.3 as commit 7a3393bfaccd569223af30a92f0ad9253611faa7