57659[TASK] Add hint to Site Configuration without pages
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mona Muzaffar +1
-
Verified V +2
- Frank Nägler +2
- Andreas Wolf +2
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1011
-
Mathias Brodala uploaded patch set 1 07/23/18, 12:54
-
Mathias Brodala commented on patch set 1 07/23/18, 12:55
Notice that the indentation change comes from the .editorconfig. -
TYPO3com voted on patch set 1 V +1 07/23/18, 13:01 Completed build in 06m 42s on Mon, 23 Jul, 03:01 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25668
-
Georg Ringer commented on patch set 1 07/23/18, 16:47
Overview.html:89so use inline VH syntax there as well -
Mathias Brodala commented on patch set 1 07/24/18, 07:03
Overview.html:89ReplyNot sure what you mean. Inline syntax is only necessary for tag attribute content, in all other cases tag syntax should be preferred. -
Georg Ringer commented on patch set 1 07/24/18, 07:29
IMO inline is preferred as it saves 1 regex and is faster... but actually we don't have any written rules there, right? -
Mona Muzaffar voted on patch set 1 V +1 CR +1 08/10/18, 15:45
-
Anja Leichsenring commented on patch set 1 08/10/18, 16:26
locallang_siteconfiguration.xlf:19"add a page" is the message, right? What means you use (page tree, list module, page module) should not matter. So this label should not be so specific. -
Andreas Wolf commented on patch set 1 V +2 08/12/18, 09:25
I'd like to have the label issue solved, from a functional PoV this is fine, though.locallang_siteconfiguration.xlf:19Reply UnresolvedAs this is probably most relevant for people totally new to TYPO3 (or not so experienced in setting up from scratch at least), this is fine IMO; we could rephrase it to "Web > Page or Web > List" to be even more specific? -
Frank Nägler voted on patch set 1 V +2 CR +2 08/13/18, 09:35
-
Frank Nägler merged patch set 2 08/13/18, 09:36