Review main Merged

57660[TASK] Update php-cs-fixer to latest minor

Christian Kuhn CR +2 V +2 Normal +59 −19 updated 07/23/18, 14:41

Commit message

Updates friendsofphp/php-cs-fixer from 2.11.1 to 2.12.2
The 'no_unused_imports' scanner is a bit more picky and
finds another unused import fixed along with the update.

composer update friendsofphp/php-cs-fixer

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 07/23/18, 13:57

  2. Christian Kuhn commented on patch set 1 07/23/18, 13:59

    running this one through manually triggered nightly which scans the entire core for cgl violations and non only given patch. i'll merge if that goes green.
  3. TYPO3com voted on patch set 1 V +1 07/23/18, 14:07 Completed build in 09m 37s on Mon, 23 Jul, 04:07 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25669

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 07/23/18, 14:08

  5. Wouter Wolters commented on patch set 1 07/23/18, 14:08

    8.7 too?
  6. Christian Kuhn commented on patch set 1 CR -1 07/23/18, 14:11

    good point. will check 8.7 and backport if possible
  7. Christian Kuhn updated the commit message in patch set 2 07/23/18, 14:17

  8. Christian Kuhn commented on patch set 2 07/23/18, 14:17

    8.7 pending.
  9. TYPO3com voted on patch set 2 V +1 07/23/18, 14:27 Completed build in 09m 30s on Mon, 23 Jul, 04:27 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25670

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 07/23/18, 14:41

  11. Christian Kuhn merged patch set 3 07/23/18, 14:41