Review main Merged

57662[TASK] Update codeception to latest patch level

Christian Kuhn CR +2 V +2 Hard +158 −94 updated 07/23/18, 15:45

Commit message

composer update codeception/codeception --with-dependencies

Updates codeception from 2.4.1 to 2.4.4 and brings
phpunit 7.1.4 to 7.1.5 along with some deeper dependencies.
The younger phpunit bundle seems to be a bit more picky on
string assertions, so we need to fix two unit tests that
silently used the bug before.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/23/18, 15:18

  2. Christian Kuhn commented on patch set 1 07/23/18, 15:19

    master only for now, v8 needs special care.
  3. TYPO3com voted on patch set 1 V +1 07/23/18, 15:28 Completed build in 09m 22s on Mon, 23 Jul, 05:28 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25674

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/23/18, 15:45

  5. Benni Mack voted on patch set 1 V +2 CR +2 07/23/18, 15:45

  6. Benni Mack merged patch set 2 07/23/18, 15:45