57671[TASK] Deprecate signals during extension installation
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
- Wouter Wolters +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-82368-SignalAfterExtensionConfigurationWriteRemoved.rst4+4 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85462-SignalHasInstalledExtensionsDeprecated.rstnew+40 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85462-SignalTablesDefinitionIsBeingBuiltDeprecated.rstnew+42 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −0
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+17 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+0 −83
- typo3/sysext/extensionmanager/Tests/UnitDeprecated/Utility/InstallUtilityTest.phpnew+145 −0
Review log 1618
-
Nicole Hummel uploaded patch set 1 07/24/18, 09:42
-
TYPO3com voted on patch set 1 V +1 07/24/18, 09:49 Completed build in 07m 27s on Tue, 24 Jul, 11:49 AM Test Summary: 33440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25714
-
Mathias Brodala commented on patch set 2 07/24/18, 10:16
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 07/24/18, 10:23 Completed build in 06m 47s on Tue, 24 Jul, 12:23 PM Test Summary: 33440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25715
-
Helmut Hummel voted on patch set 2 CR +1 07/24/18, 16:56
-
Markus Klein voted on patch set 2 CR +1 07/24/18, 20:18
-
Wouter Wolters voted on patch set 2 CR +1 07/25/18, 06:55
-
Jan Stockfisch commented on patch set 2 CR -1 07/25/18, 08:03
Breaking-82368-SignalAfterExtensionConfigurationWriteRemoved.rst:35Is it correct that this .rst of version 9.0 is being edited? Thought .rst files won't not be edited. Even if the migration has been deprecated. -
Helmut Hummel commented on patch set 2 07/25/18, 10:26
Breaking-82368-SignalAfterExtensionConfigurationWriteRemoved.rst:35ReplyYes, this is correct, because the rst mentions a signal to be used as alternative, that is deprecated with this change. What is your suggestion here? -
Jan Stockfisch commented on patch set 2 CR 0 07/25/18, 11:10
Breaking-82368-SignalAfterExtensionConfigurationWriteRemoved.rst:35ReplyIf it's correct, I'll remove my vote. My suggestion is simple: Not changing .rst files in general. "hasInstalledExtensions" has been mentioned in 9.0 to be the way to go for migrations. To be a bit more strict and dramatic, this is still valid until now. While using "afterExtensionInstall" between v9.0 and v9.4 you may not end up with the solution you need/want. With this very patch, "hasInstalledExtensions" has been deprecated and a new way-to-migrate has been introduced. This should be enough IMHO. Of curse this very scenario is not as big of a deal and TYPO3 9 is sill in heavy development, so I'm fine with this. -
Helmut Hummel commented on patch set 2 07/25/18, 11:24
Breaking-82368-SignalAfterExtensionConfigurationWriteRemoved.rst:35ReplyIf we don't change rsts and people, when upgrading from 8LTS read them in order, in worst case, they will do duplicate work, changing their code multiple times. I consider it more important to support upgraders as good as possible than having immutable rsts. On top, what we suggest in this very rst not, works as well for people using 9.3, as it works for those that will be using 9LTS. We did change older rsts in the past for that reason and I still consider it a good thing. -
Markus Klein commented on patch set 2 07/25/18, 12:23
how to "test" this change in a sensible way? -
Nicole Hummel commented on patch set 2 07/25/18, 12:40
@Markus: You might add some deprecated slots and watch the deprecation messages -
Markus Klein commented on patch set 2 07/25/18, 12:50
But hasInstalledExtensions does not throw anything. (Do we have a way to deprecate signals? Deprecation message when registering slots, or when fired?) -
Nicole Hummel commented on patch set 2 07/25/18, 13:07
@Markus: unfortunately currently there is no way to deprecate an signal correctly. At least no one that does not expect any return values. The dispatcher doesn't offer any methods to get registered slots for a signal. The registration is saved in an internal dispatcher property. I just did the deprecation like we used to deprecate it for other signals. -
Markus Klein voted on patch set 2 V +1 07/25/18, 13:09
-
Christian Kuhn voted on patch set 2 V +2 CR +2 07/25/18, 22:14
-
Christian Kuhn merged patch set 3 07/25/18, 22:14