Review main Merged

57673[TASK] Use same ordering in page module for title and icons

Georg Ringer CR +2 V +2 Easy +8 −11 updated 07/26/18, 20:41

Commit message

Use same ordering for content elements in the page module for
the default language and translations.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1620

  1. Georg Ringer uploaded patch set 1 07/24/18, 13:12

  2. Markus Klein voted on patch set 1 CR +1 07/24/18, 13:15

  3. TYPO3com voted on patch set 1 V +1 07/24/18, 13:19 Completed build in 07m 06s on Tue, 24 Jul, 03:19 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25725

  4. Georg Ringer updated the commit message in patch set 2 07/24/18, 13:22

  5. TYPO3com voted on patch set 2 V +1 07/24/18, 13:31 Completed build in 09m 18s on Tue, 24 Jul, 03:31 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25726

  6. Wouter Wolters voted on patch set 2 CR +1 07/24/18, 13:42

  7. Georg Ringer voted on patch set 2 V +2 CR +2 07/24/18, 13:48

  8. Georg Ringer voted on patch set 2 V 0 CR 0 07/24/18, 14:10

  9. Georg Ringer wrote 07/24/18, 14:10

    Removed reviewer Georg Ringer.
  10. Markus Klein commented on patch set 2 07/24/18, 14:18

    The translate button is then next to the page title, which looks a bit strange.
  11. Markus Klein commented on patch set 2 07/24/18, 14:18

  12. Georg Ringer uploaded patch set 3 07/24/18, 16:22

  13. TYPO3com voted on patch set 3 V -1 07/24/18, 16:22 Completed build in 10s on Tue, 24 Jul, 06:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25731

  14. Georg Ringer uploaded patch set 4 07/24/18, 16:24

  15. TYPO3com voted on patch set 4 V +1 07/24/18, 16:32 Completed build in 07m 53s on Tue, 24 Jul, 06:32 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25732

  16. Markus Klein voted on patch set 4 V +1 CR +1 07/24/18, 16:37

  17. Riccardo De Contardi voted on patch set 4 V +1 07/24/18, 20:29

  18. Mathias Schreiber voted on patch set 4 V +1 CR +1 07/26/18, 13:59

  19. Christian Kuhn voted on patch set 4 V +2 CR +2 07/26/18, 20:41

  20. Christian Kuhn merged patch set 5 07/26/18, 20:41