Review main Merged

57674[BUGFIX] Context User Aspect must deal with empty fe_user

Benni Mack CR +2 V +2 Easy +6 −6 updated 07/25/18, 16:03

Commit message

TSFE->fe_user is set to '' by default, but UserAspect
expects "null".

Extensions like solr set up their own TSFE object which
is fine, however they still access gr_list which is OK,
because it is deprecated. However, a deprecation
message must be thrown, and NOT a strict typing warning.

UserAspect expects either "null" or object of type
AbstractUserAuthentication, but TSFE delivers '' by
default.

Modifying '' would not be an option as this would be
(slightly but still) breaking.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Benni Mack uploaded patch set 1 07/24/18, 14:56

  2. Markus Klein voted on patch set 1 CR +1 07/24/18, 15:01

  3. Georg Ringer voted on patch set 1 V +1 CR +1 07/24/18, 15:02

  4. TYPO3com voted on patch set 1 V +1 07/24/18, 15:04 Completed build in 07m 53s on Tue, 24 Jul, 05:04 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25728

  5. Markus Klein commented on patch set 1 CR 0 07/24/18, 15:18

    should that be done in typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php:202 too maybe?
  6. Markus Klein voted on patch set 1 CR -1 07/24/18, 15:20

  7. Benni Mack uploaded patch set 2 07/25/18, 10:33

  8. TYPO3com voted on patch set 2 V +1 07/25/18, 10:41 Completed build in 07m 19s on Wed, 25 Jul, 12:41 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25754

  9. Markus Klein voted on patch set 2 V +1 CR +1 07/25/18, 12:23

  10. Andreas Kienast voted on patch set 2 CR +1 07/25/18, 12:32

  11. Georg Ringer voted on patch set 2 V +2 CR +2 07/25/18, 16:03

  12. Georg Ringer merged patch set 3 07/25/18, 16:03