Review main Merged

57676[BUGFIX] Determine default language as origin correctly

Andreas Kienast CR +2 V +2 Normal +47 −7 updated 07/27/18, 11:25

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Nicole Hummel +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1112

  1. Andreas Kienast uploaded patch set 1 07/25/18, 06:53

  2. Markus Klein commented on patch set 1 07/25/18, 06:57

    Please have a look at my changes in https://review.typo3.org/#/c/57628/12/typo3/sysext/backend/Tests/Functional/Domain/Repository/Localization/LocalizationRepositoryTest.php too. I modified those tests as well to not have this "false" as return value
  3. TYPO3com voted on patch set 1 V +1 07/25/18, 07:01 Completed build in 07m 40s on Wed, 25 Jul, 09:01 AM Test Summary: 33451 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25738

  4. Markus Klein voted on patch set 1 V +1 CR +1 07/25/18, 09:09

  5. Wouter Wolters voted on patch set 1 CR +1 07/25/18, 09:10

  6. Mathias Schreiber voted on patch set 1 V +1 CR +1 07/26/18, 14:06

  7. Tymoteusz Motylewski voted on patch set 1 CR +1 07/26/18, 15:51

  8. Nicole Hummel commented on patch set 1 V -1 07/26/18, 18:07

    Does not work as expected. I'm using the translate button in page module. I have elements already translated and added a new content element in default language. I thought the patch prevents already translated elements from being shown in the wizard?
  9. Andreas Kienast commented on patch set 1 CR -1 07/26/18, 18:45

    No, the patch should only ensure that the sys_language_uid is found as well. But your described behavior sounds like a side issue, will take a look tomorrow.
  10. Andreas Kienast commented on patch set 1 CR 0 07/27/18, 06:08

    Sorry Nicole, I can't reproduce your reported issue. I have created a content element in the default language and translated it. Afterwards, I created another content element in the default language and did the translation process again, the wizard only shows the new content element.
  11. Nicole Hummel commented on patch set 1 V +2 CR +2 07/27/18, 11:24

    Thanks Andi for sorting things out.
  12. Nicole Hummel merged patch set 2 07/27/18, 11:25