Review main Merged

57683[TASK] Deprecate eID registration with a script to a file

Wouter Wolters CR +2 V +2 Easy +49 −1 updated 07/25/18, 22:08

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1218

  1. Wouter Wolters uploaded patch set 1 07/25/18, 18:38

  2. TYPO3com voted on patch set 1 V +1 07/25/18, 18:47 Completed build in 08m 39s on Wed, 25 Jul, 08:47 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25768

  3. Markus Klein commented on patch set 1 07/25/18, 18:48

    EidHandler.php:68

    I would use a more custom example and a leading backslash. \MyCompany\Extension\Eid\MyClass::myMethod

    EidHandler.php:68

    do we specify also the minor version?
  4. Christian Kuhn commented on patch set 1 CR -1 07/25/18, 21:19

    Deprecation-85646-DeprecateEIDImplementedAsScript.rst:12

    this is a bit sparse. i'll try to come up with something more verbose.

    EidHandler.php:68 Reply

    Done

    EidHandler.php:68 Reply

    Done
  5. Christian Kuhn uploaded patch set 2 07/25/18, 21:34

  6. Christian Kuhn commented on patch set 3 07/25/18, 21:39

    Published edit on patch set 2.
  7. Christian Kuhn commented on patch set 4 07/25/18, 21:39

    Published edit on patch set 3.
  8. Christian Kuhn commented on patch set 5 07/25/18, 21:41

    Published edit on patch set 4.
  9. TYPO3com voted on patch set 2 V +1 07/25/18, 21:42 Completed build in 08m 14s on Wed, 25 Jul, 11:42 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25788

  10. Markus Klein commented on patch set 5 07/25/18, 21:46

    Deprecation-85646-DeprecateEIDImplementedAsScript.rst:20

    leading backslash missing

    Deprecation-85646-DeprecateEIDImplementedAsScript.rst:42

    same here
  11. Markus Klein commented on patch set 6 07/25/18, 21:46

    Published edit on patch set 5.
  12. Markus Klein voted on patch set 6 V +1 CR +1 07/25/18, 21:47

  13. TYPO3com voted on patch set 3 V +1 07/25/18, 21:49 Completed build in 10m 24s on Wed, 25 Jul, 11:49 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25790

  14. TYPO3com voted on patch set 4 V +1 07/25/18, 21:51 Completed build in 10m 02s on Wed, 25 Jul, 11:51 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25791

  15. TYPO3com voted on patch set 5 V +1 07/25/18, 21:52 Completed build in 08m 50s on Wed, 25 Jul, 11:52 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25792

  16. TYPO3com voted on patch set 6 V +1 07/25/18, 21:54 Completed build in 07m 41s on Wed, 25 Jul, 11:54 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25793

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 07/25/18, 22:08

  18. Christian Kuhn merged patch set 7 07/25/18, 22:08