57683[TASK] Deprecate eID registration with a script to a file
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1218
-
Wouter Wolters uploaded patch set 1 07/25/18, 18:38
-
TYPO3com voted on patch set 1 V +1 07/25/18, 18:47 Completed build in 08m 39s on Wed, 25 Jul, 08:47 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25768
-
Markus Klein commented on patch set 1 07/25/18, 18:48
EidHandler.php:68do we specify also the minor version? -
Christian Kuhn commented on patch set 1 CR -1 07/25/18, 21:19
Deprecation-85646-DeprecateEIDImplementedAsScript.rst:12this is a bit sparse. i'll try to come up with something more verbose.EidHandler.php:68ReplyDoneEidHandler.php:68ReplyDone -
Christian Kuhn uploaded patch set 2 07/25/18, 21:34
-
Christian Kuhn commented on patch set 3 07/25/18, 21:39
Published edit on patch set 2. -
Christian Kuhn commented on patch set 4 07/25/18, 21:39
Published edit on patch set 3. -
Christian Kuhn commented on patch set 5 07/25/18, 21:41
Published edit on patch set 4. -
TYPO3com voted on patch set 2 V +1 07/25/18, 21:42 Completed build in 08m 14s on Wed, 25 Jul, 11:42 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25788
-
Markus Klein commented on patch set 5 07/25/18, 21:46
Deprecation-85646-DeprecateEIDImplementedAsScript.rst:20leading backslash missingDeprecation-85646-DeprecateEIDImplementedAsScript.rst:42same here -
Markus Klein commented on patch set 6 07/25/18, 21:46
Published edit on patch set 5. -
Markus Klein voted on patch set 6 V +1 CR +1 07/25/18, 21:47
-
TYPO3com voted on patch set 3 V +1 07/25/18, 21:49 Completed build in 10m 24s on Wed, 25 Jul, 11:49 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25790
-
TYPO3com voted on patch set 4 V +1 07/25/18, 21:51 Completed build in 10m 02s on Wed, 25 Jul, 11:51 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25791
-
TYPO3com voted on patch set 5 V +1 07/25/18, 21:52 Completed build in 08m 50s on Wed, 25 Jul, 11:52 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25792
-
TYPO3com voted on patch set 6 V +1 07/25/18, 21:54 Completed build in 07m 41s on Wed, 25 Jul, 11:54 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25793
-
Christian Kuhn voted on patch set 6 V +2 CR +2 07/25/18, 22:08
-
Christian Kuhn merged patch set 7 07/25/18, 22:08
EidHandler.php:68